Add dark mode/light theme - Vanilla.js #290
Conversation
29deepanshutyagi
requested review from
michaelneale,
jiyoonie9,
acekyd,
angiejones,
blackgirlbytes,
mistermoe,
KendallWeihe,
EbonyLouis,
nitro-neal,
leordev and
finn-block
as code owners
| @@ -10,7 +10,7 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| - name: Get issue number from PR body | |||
| id: issue_number | |||
| uses: actions/github-script@v7 | |||
| uses: actions/github-script@v6 | |||
There was a problem hiding this comment.
hmm I don't think you want these changes in your PR 🤔
There was a problem hiding this comment.
Thanks for the contribution @29deepanshutyagi , but I can't approve and merge. You might need to rebase. It seems like you're adding changes to GitHub Actions and Code Owner files. @finn-tbd just updated these, and we don't want those changes to revert. There's about 57 files changed here that I think will revert our repository.
Please remove all changes that are irrelevant to adding dark mode and light mode.
|
|
||
| - name: Log in to the container registry | ||
| uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0 | ||
| uses: docker/login-action@0d4c9c5ea7693da7b068278f7b52bda2a190a446 # v3.2.0 |
There was a problem hiding this comment.
There shouldn't be changes here either!
|
If this is too much to rebase, I might suggest closing this PR, pulling the latest changes from our repo, creating a new branch with your changes, and opening a new PR. |
There was a problem hiding this comment.
My last comment is...I don't see the support for dark mode / light mode reflected in your PR unfortunately. I don't see a button to manually test it.
And then please remember for each of your PRs to include a test, please and thank you. So we need a written test to make sure that light and dark mode are working.
|
ok |
issue #84