Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12588] Add tests for student list component #12854

Merged

Conversation

cedricongjh
Copy link
Contributor

Part of #12588

Outline of Solution
Add tests to improve code coverage of student list component
Removed getAriaSort for student list component, as it is unused (sortable-table's getAriaSort is being used instead)

Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu added the s.FinalReview The PR is ready for final review label Feb 29, 2024
@cedricongjh cedricongjh merged commit 0ed34c9 into TEAMMATES:master Mar 2, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants