[#12048] Add database unique constraints and length changes

src/it/java/teammates/it/sqllogic/core/FeedbackQuestionsLogicIT.java

@@ -55,7 +55,7 @@ public void testCreateFeedbackQuestion() throws InvalidParametersException, Enti
         FeedbackTextQuestionDetails newQuestionDetails = new FeedbackTextQuestionDetails("New question text.");
         List<FeedbackParticipantType> showTos = new ArrayList<>();
         showTos.add(FeedbackParticipantType.INSTRUCTORS);
-        FeedbackQuestion newQuestion = FeedbackQuestion.makeQuestion(fs, 6, "This is a new text question",
+        FeedbackQuestion newQuestion = FeedbackQuestion.makeQuestion(fs, 12, "This is a new text question",
                 FeedbackParticipantType.STUDENTS, FeedbackParticipantType.OWN_TEAM_MEMBERS, -100,
                 showTos, showTos, showTos, newQuestionDetails);
 

src/it/java/teammates/it/ui/webapi/CreateFeedbackQuestionActionIT.java

@@ -64,31 +64,31 @@ protected void testExecute() throws Exception {
 
         ______TS("null question type");
 
-        FeedbackQuestionCreateRequest createRequest = getTypicalTextQuestionCreateRequest();
+        FeedbackQuestionCreateRequest createRequest = getTypicalTextQuestionCreateRequest(10);
         createRequest.setQuestionType(null);
         verifyHttpRequestBodyFailure(createRequest, params);
 
         ______TS("Invalid questionNumber");
 
-        createRequest = getTypicalTextQuestionCreateRequest();
+        createRequest = getTypicalTextQuestionCreateRequest(10);
         createRequest.setQuestionNumber(0);
         verifyHttpRequestBodyFailure(createRequest, params);
 
         ______TS("Failure: Invalid giverType");
 
-        createRequest = getTypicalTextQuestionCreateRequest();
+        createRequest = getTypicalTextQuestionCreateRequest(10);
         createRequest.setGiverType(FeedbackParticipantType.NONE);
         verifyHttpRequestBodyFailure(createRequest, params);
 
         ______TS("Failure: empty question brief");
 
-        createRequest = getTypicalTextQuestionCreateRequest();
+        createRequest = getTypicalTextQuestionCreateRequest(10);
         createRequest.setQuestionBrief("");
         verifyHttpRequestBodyFailure(createRequest, params);
 
         ______TS("Typical case");
 
-        createRequest = getTypicalTextQuestionCreateRequest();
+        createRequest = getTypicalTextQuestionCreateRequest(10);
         CreateFeedbackQuestionAction a = getAction(createRequest, params);
         JsonResult r = getJsonResult(a);
 
@@ -103,7 +103,7 @@ protected void testExecute() throws Exception {
 
         ______TS("Custom number of entity to give feedback to");
 
-        createRequest = getTypicalTextQuestionCreateRequest();
+        createRequest = getTypicalTextQuestionCreateRequest(11);
         createRequest.setNumberOfEntitiesToGiveFeedbackToSetting(NumberOfEntitiesToGiveFeedbackToSetting.CUSTOM);
         createRequest.setCustomNumberOfEntitiesToGiveFeedbackTo(100);
         createRequest.setGiverType(FeedbackParticipantType.STUDENTS);
@@ -152,9 +152,9 @@ protected void testAccessControl() throws Exception {
                 fs.getCourse(), Const.InstructorPermissions.CAN_MODIFY_SESSION, submissionParams);
     }
 
-    private FeedbackQuestionCreateRequest getTypicalTextQuestionCreateRequest() {
+    private FeedbackQuestionCreateRequest getTypicalTextQuestionCreateRequest(int questionNumber) {
         FeedbackQuestionCreateRequest createRequest = new FeedbackQuestionCreateRequest();
-        createRequest.setQuestionNumber(2);
+        createRequest.setQuestionNumber(questionNumber);
         createRequest.setQuestionBrief("this is the brief");
         createRequest.setQuestionDescription("this is the description");
         FeedbackTextQuestionDetails textQuestionDetails = new FeedbackTextQuestionDetails();

src/it/resources/data/FeedbackResponsesITBundle.json

@@ -1022,7 +1022,7 @@
         "questionType": "TEXT"
       },
       "description": "Feedback question with no responses",
-      "questionNumber": 5,
+      "questionNumber": 6,
       "giverType": "SELF",
       "recipientType": "NONE",
       "numOfEntitiesToGiveFeedbackTo": -100,

src/it/resources/data/typicalDataBundle.json

@@ -1018,7 +1018,7 @@
         "questionType": "TEXT"
       },
       "description": "Feedback question with no responses",
-      "questionNumber": 5,
+      "questionNumber": 6,
       "giverType": "SELF",
       "recipientType": "NONE",
       "numOfEntitiesToGiveFeedbackTo": -100,

src/main/java/teammates/storage/sqlentity/FeedbackQuestion.java

@@ -19,6 +19,7 @@
 import jakarta.persistence.ManyToOne;
 import jakarta.persistence.OneToMany;
 import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
 
 import org.hibernate.annotations.UpdateTimestamp;
 
@@ -39,7 +40,10 @@
  * Represents a feedback question.
  */
 @Entity
-@Table(name = "FeedbackQuestions")
+@Table(name = "FeedbackQuestions", uniqueConstraints = {
+        @UniqueConstraint(name = "Unique question number per session",
+            columnNames = { "questionNumber", "sessionId" }),
+})
 @Inheritance(strategy = InheritanceType.SINGLE_TABLE)
 public abstract class FeedbackQuestion extends BaseEntity implements Comparable<FeedbackQuestion> {
     @Id
@@ -55,7 +59,7 @@ public abstract class FeedbackQuestion extends BaseEntity implements Comparable<
     @Column(nullable = false)
     private Integer questionNumber;
 
-    @Column(nullable = true)
+    @Column(nullable = true, length = 2000)
     private String description;
 
     @Column(nullable = false)

src/main/java/teammates/storage/sqlentity/Section.java

@@ -14,6 +14,7 @@
 import jakarta.persistence.ManyToOne;
 import jakarta.persistence.OneToMany;
 import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
 
 import org.hibernate.annotations.OnDelete;
 import org.hibernate.annotations.OnDeleteAction;
@@ -26,7 +27,9 @@
  * Represents a Section.
  */
 @Entity
-@Table(name = "Sections")
+@Table(name = "Sections", uniqueConstraints = {
+        @UniqueConstraint(name = "Unique section name per course", columnNames = { "name", "courseId" }),
+})
 public class Section extends BaseEntity {
     @Id
     private UUID id;

src/main/java/teammates/storage/sqlentity/Student.java

@@ -18,7 +18,7 @@
 @Entity
 @Table(name = "Students")
 public class Student extends User {
-    @Column(nullable = false)
+    @Column(nullable = false, length = 2000)
     private String comments;
 
     protected Student() {