Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12655] Instructor Edit Session Page: If make session visible is later than submission opening time, automatically default to opening time #13143

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

Respirayson
Copy link
Contributor

Fixes #12655

Outline of Solution

Added logic to ensure that when the submission opening date and time are changed, the session visibility date and time are also adjusted if necessary.

Introduced configureSessionVisibleDateTime to adjust the session visibility date and time if they are earlier than the submission opening date and time.

Untitled.video.-.Made.with.Clipchamp.2.mp4

Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work on this

@domoberzin domoberzin added the s.FinalReview The PR is ready for final review label Jul 12, 2024
Copy link
Contributor

@mingyuanc mingyuanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingyuanc mingyuanc merged commit 61df45a into TEAMMATES:master Jul 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.FinalReview The PR is ready for final review
Projects
None yet
3 participants