Update for 1.13 (kind of) #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But this time with setting the formatter to only affect the lines that got edited.
The absolute minimal changes needed to make this feature work.
- Made the gui package easier to use in libraries - Added rudimental documentation, mostly to the new features
The library API is still work in progress.
Fixed a lot of missing things and typos
Rendering should have no big bugs anymore. Logging is on its way to improvement
But it kind of works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I started updating the codebase to be able to load 1.13 worlds and, that might have escalated quite a bit. Through the process I rewrote almost every single line of code, even if I kept the rough structure. I split the repository into four modules and converted it to Gradle because Maven didn't want to. (If you are wondering, I started a fresh repository and migrated the code gradually and copied everything back for this pull request).
A lot of the features got removed and not added back in yet, and the Eclipse project is kind of broken again, but calling something like
./gradlew -Dorg.gradle.java.home=/usr/lib/jvm/java-8-openjdk :BlockMap-standalone:shadowJarspits out a fat jar that might render worlds with a GUI :) . I also renamed the project so this should be reverted before merging.@TOGoS I don't expect you to merge this big mess. This will require a lot of additional work and I probably won't do it. Unless you are absolutely willing to get this merged, I will continue this in my own repository and perhaps mirror it on this branch.
Fixes #39