Skip to content

Commit

Permalink
schema: add support for additional camera models in camera intrinsics (
Browse files Browse the repository at this point in the history
…#86)

* schema: add support for additional camera models in camera intrinsics proto

* fix: removed enum in camera intrinsics
  • Loading branch information
chrisochoatri authored Jun 30, 2022
1 parent f1ee0f2 commit bbc74d6
Show file tree
Hide file tree
Showing 2 changed files with 180 additions and 3 deletions.
37 changes: 37 additions & 0 deletions dgp/proto/geometry.proto
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,41 @@ message CameraIntrinsics {
double cx = 3;
double cy = 4;
double skew = 5;

// Camera distortion parameters, copied over from Parallel Domain
// These include the default opencv distorition model parameters (Brown Conrady)
// See https://en.wikipedia.org/wiki/Distortion_(optics) and opencv calibrateCamera for details
// Additionally the Double Sphere Camera Model (https://arxiv.org/pdf/1807.08957.pdf) by Usenko, Demmel, and Cremers
// is an excellent reference
double fov = 6;
int32 fisheye = 7;
double k1 = 8;
double k2 = 9;
double k3 = 10;
double k4 = 11;
double k5 = 12;
double k6 = 13;
double p1 = 14;
double p2 = 15;

// Additional parameters for thin prism model
double s1 = 16;
double s2 = 17;
double s3 = 18;
double s4 = 19;

// Additional parameters for tilted sensor model
double taux = 20;
double tauy = 21;

// Additional parameters for UCM and EUCM camera models
double alpha = 22;
double beta = 23;

// Additional parameters for FOV camera model
double w = 24;

// Parameters for Double Sphere model
double xi = 25;

}
146 changes: 143 additions & 3 deletions dgp/proto/geometry_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit bbc74d6

Please sign in to comment.