Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guide-sync): Add more groups for the 3rd party sync applications #2160

Merged
merged 36 commits into from
Feb 13, 2025

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented Dec 15, 2024

Pull Request

Purpose

Add more groups for the 3rd party sync applications so the end user can easily add/choose certain groups to their QP Sync (Sync
a complete Quality Profile from the guide with all the settings like Custom Formats, Quality Source, Minimum Custom Format Score, Upgrade Until Custom Format Score, etc)

Approach

  • Add group [HDR formats] Dolby Vision Incompatible Devices | (add DV (WEBDL) to your QP)
  • Add group [HDR Formats] DV HDR10+ and HDR10+ Boost | (add the DV HDR10+ and HDR10+ Boost to your QP)
  • Add group [Optional] Miscellaneous | (Choose any CF from the Miscellaneous column)
  • Add group [Optional] Movie Versions | (Choose any Movie version you want)
  • Add group [Optional] SDR | (Choose if you want to use SDR or SDR (no WEBDL))
  • Add group [Required] Golden Rule | (Choose if you want to use x265 (HD) or x265 (no HDR/DV))
  • Add group [Streaming Services] Anime
  • Add group [Streaming Services] Asian
  • Add group [Streaming Services] Dutch
  • Add group [Streaming Services] French
  • Add group [Streaming Services] Miscellaneous
  • Add group [Streaming Services] UK
  • Add group French Source Groups | (Remux Tiers, UHD Bluray Tiers, HD Bluray Tiers and WEB Tiers)
  • Add group German Source Groups | (Remux Tiers, Bluray Tiers and WEB Tiers)
  • Add group HQ Release Groups | (Remux Tiers, UHD Bluray Tiers, HD Bluray Tiers and WEB Tiers)

Open Questions and Pre-Merge TODOs

  • Remove HDR10+ boost and DV (WEBDL) from the Misc UHD group
  • Check group names so they are better sorted and matched together
  • Wait till Notifarr supports the default condition in the groups "default": true
  • Once Notifiarr supports the default condition in the groups, review QP so they don't have the same CF as in the groups set they are allowed to use!
  • Recheck quality_profiles excludes

Requirements

@TRaSH- TRaSH- marked this pull request as draft December 15, 2024 21:10
@github-actions github-actions bot added the Area: Backend Backend Changes, not related to a specific section label Dec 15, 2024
@TRaSH- TRaSH- changed the title feat(guide-sync): Added more groups feat(guide-sync): Added more groups for the 3rd party sync applications Dec 15, 2024
@TRaSH- TRaSH- changed the title feat(guide-sync): Added more groups for the 3rd party sync applications feat(guide-sync): Add more groups for the 3rd party sync applications Dec 15, 2024
@bakerboy448
Copy link
Contributor

https://discord.com/channels/492590071455940612/1317973099966369852

@TRaSH- TRaSH- self-assigned this Dec 26, 2024
`"required": true` = It means you cant use that group without that format, it can not be turned off!
@TRaSH- TRaSH- marked this pull request as ready for review January 12, 2025 21:15
@TRaSH- TRaSH- added the Do Not Merge Do Not Merge label Jan 12, 2025
@github-actions github-actions bot added the Status: Conflicted Pull Request is Conflicted label Jan 13, 2025
@github-actions github-actions bot added Status: Conflicted Pull Request is Conflicted and removed Status: Conflicted Pull Request is Conflicted labels Jan 23, 2025
@github-actions github-actions bot removed the Status: Conflicted Pull Request is Conflicted label Jan 26, 2025
@TRaSH- TRaSH- marked this pull request as draft January 26, 2025 15:49
@TRaSH- TRaSH- removed the Do Not Merge Do Not Merge label Jan 26, 2025
@github-actions github-actions bot added the Status: Conflicted Pull Request is Conflicted label Feb 1, 2025
@github-actions github-actions bot removed the Status: Conflicted Pull Request is Conflicted label Feb 1, 2025
@TRaSH- TRaSH- marked this pull request as ready for review February 9, 2025 20:12
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Deploying with ⚡ Cloudflare Pages

Latest commit:98f4446fd3b6379a14249474826e375e401ed6ea
Status: ✅  Deploy successful!
Preview URL:https://b73d8d4e.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2160.trash-guides-6xu.pages.dev

Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:293e6cce975264b6d9f6544b8390944089e89437
Status: ✅  Deploy successful!
Preview URL:https://c9fd2174.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2160.trash-guides-6xu.pages.dev

Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:c7355ec3b73eb2adc6e3ae7243bf2b085943c481
Status: ✅  Deploy successful!
Preview URL:https://c93741ac.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2160.trash-guides-6xu.pages.dev

@TRaSH- TRaSH- merged commit 4074e4f into master Feb 13, 2025
9 checks passed
@TRaSH- TRaSH- deleted the feat/guide-sync-add-more-groups branch February 13, 2025 19:06
SeiyaGame pushed a commit to SeiyaGame/Guides that referenced this pull request Feb 16, 2025
…TRaSH-Guides#2160)

* feat(guide-sync): Added more groups

* fix: JSONDecodeError

* Added: group Asian Streaming Services

* Added: group UK Streaming Services

* Added: group French Streaming Services

* Added: group Dutch Streaming Services

* Added: group Anime Streaming Services

* Renamed the JSON files so they can be ordered together.

* Add Release Groups

* Updated QP excludes

* Update dv-hdr10-and-hdr10-boost.json

* Changed group names so they are better sorted and matched together

* Remove HDR10+ boost and DV (WEBDL) from the Misc UHD group

* Removed: `x265 (no HDR/DV)` because they aren't part of this profile

* Improved Group name and add `x265 (no HDR/DV)` to the Sonarr UHD Misc

* Removed because they were merged into a single group.

* Added: group SDR

* Add: group golden rule

* Renamed JSON name so they are better sorted

* Added: SQP to the exclude because anime never can be part of the SQP

* Added: descriptions and other changes

* Added: more misc CF

* excludes this group for all QP

* Add group Misc Streaming Services

* fixed: `"required": true` to ` "required": false`

`"required": true` = It means you cant use that group without that format, it can not be turned off!

* Improved Group descriptions

* Added fix for PR#2241

* several needed changes after a talk with the dev of a 3rd party app

* Removed the German 4k excludes

* Added: NEW German `[German] HD Remux + WEB` to the exclude

* Changed order

* Added: [Optional] Resolutions but still disabled for all profiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants