Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guide-sync): Add Anime profiles for sonarr and radarr #2267

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jetuser
Copy link

@jetuser jetuser commented Feb 9, 2025

Pull Request

Purpose

First pass at creating quality profile for Anime configurations on Sonarr and Radarr

Approach

Pulled the current guides off the web and codified them into the proposed quality files in this PR

Requirements

@github-actions github-actions bot added the Area: Backend Backend Changes, not related to a specific section label Feb 9, 2025
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Deploying with ⚡ Cloudflare Pages

Latest commit:a4a27c4ed0b1d48fcdfc1014de898ca61cde545f
Status: ✅  Deploy successful!
Preview URL:https://3e9b5cfd.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2267.trash-guides-6xu.pages.dev

@TRaSH- TRaSH- marked this pull request as ready for review February 14, 2025 20:50
@TRaSH- TRaSH- requested a review from a team February 14, 2025 20:50
Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:9d62a33d5db5b21965b30b36e0be2a66f2cc7379
Status: ✅  Deploy successful!
Preview URL:https://7f6de1e6.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2267.trash-guides-6xu.pages.dev

Copy link
Contributor

@yammes08 yammes08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions and comments.

"trash_id": "722b624f9af1e492284c4bc842153a38",
"name": "[Anime] Remux-1080p - Anime",
"trash_description": "Quality Profile that covers:<br>- SDTV, DVD<br>- HDTV 720p, 1080p<br>- WEBDL: 480p, 720, 1080p<br>- Bluray 480p, 576p, 720p, 1080p<br>- Remux 1080p",
"group": 81,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know what value this should be?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to defer to @TRaSH- here on the group id, but the rest of the values came from the existing guide for anime profiles.

"trash_id": "20e0fc959f1f1704bed501f23bdae76f",
"name": "[Anime] Remux-1080p - Anime",
"trash_description": "Quality Profile that covers:<br>- SDTV, DVD<br>- HDTV 720p, 1080p<br>- WEBDL: 480p, 720, 1080p<br>- Bluray 480p, 576p, 720p, 1080p<br>- Remux 1080p",
"group": 81,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know what value this should be?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to defer to @TRaSH- here on the group id, but the rest of the values came from the existing guide for anime profiles.

Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:bf4b6d818beeee275691399736895522ff68e022
Status: ✅  Deploy successful!
Preview URL:https://1682012c.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2267.trash-guides-6xu.pages.dev

Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:1f338a9b49d782e5a45bdb655c2381a6a5560945
Status: ✅  Deploy successful!
Preview URL:https://867b9cbc.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2267.trash-guides-6xu.pages.dev

@jetuser jetuser requested a review from yammes08 February 23, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants