Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(guide): Add quality-profile and cf-groups info to CONTRIBUTING.md #2268

Closed
wants to merge 5 commits into from
Closed

feat(guide): Add quality-profile and cf-groups info to CONTRIBUTING.md #2268

wants to merge 5 commits into from

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented Feb 9, 2025

Pull Request

Purpose

Started adding info about

  • quality-profiles
  • cf-groups

Approach

Open Questions and Pre-Merge TODOs

Requirements

@TRaSH-
Update CONTRIBUTING.md
0033c36 
Started adding info about
- quality-profiles
- cf-groups
@github-actions github-actions bot added the Area: Backend Backend Changes, not related to a specific section label Feb 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Deploying with ⚡ Cloudflare Pages

Latest commit:0033c360cd5bcfe4ef7dfafddbea5b21cf3cc1f2
Status: ✅  Deploy successful!
Preview URL:https://0f86b147.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2268.trash-guides-6xu.pages.dev

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Deploying with ⚡ Cloudflare Pages

Latest commit:5634aab1fc3fde5af8bc77431cdd5dfcab6dab01
Status: ✅  Deploy successful!
Preview URL:https://5b3fdfe8.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2268.trash-guides-6xu.pages.dev

@TRaSH- TRaSH- marked this pull request as draft February 9, 2025 22:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Deploying with ⚡ Cloudflare Pages

Latest commit:e4f503ebc657503c98190daabfe89c412bcc4766
Status: ✅  Deploy successful!
Preview URL:https://6871e5a2.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2268.trash-guides-6xu.pages.dev

bakerboy448
bakerboy448 reviewed Feb 9, 2025
View reviewed changes
Copy link
Contributor

@bakerboy448 bakerboy448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Explanation" seems redundant and unecessary given the context is it is the contributing page, by implicit definition every header should be an explanation

@github-actions GitHub Actions
Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:b84a7ac9531acd806dca542e9dd22177a96d08fb
Status: ✅  Deploy successful!
Preview URL:https://4d982908.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2268.trash-guides-6xu.pages.dev

@github-actions GitHub Actions
Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:2d1253c66d98f485b3e5f6bb80f95b78e03dcb69
Status: ✅  Deploy successful!
Preview URL:https://9adeaf5f.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2268.trash-guides-6xu.pages.dev

@TRaSH- TRaSH- closed this Feb 10, 2025
@TRaSH- TRaSH- deleted the feat(guide)-Add-`quality-profiles`-and-`cf-groups`-info-to-`CONTRIBUTING.md` branch February 10, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakerboy448 bakerboy448 bakerboy448 left review comments

Assignees
No one assigned
Labels
Area: Backend Backend Changes, not related to a specific section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TRaSH- @bakerboy448