Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guide): Add quality-profile and cf-groups info to CONTRIBUTING.md #2272

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented Feb 10, 2025

Pull Request

Purpose

Add quality-profile and cf-groups info to CONTRIBUTING.md

Approach

Added quality-profile and cf-groups info to CONTRIBUTING.md

Open Questions and Pre-Merge TODOs

Requirements

@github-actions github-actions bot added the Area: Backend Backend Changes, not related to a specific section label Feb 10, 2025
Copy link
Contributor

@TRaSH- your pull request title "Feat/guide add quality profiles and cf groups info to contributing.md" does not conform to our naming conventions.

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci(<area>): <description>

You can check your title at this regex101 link."

@TRaSH- TRaSH- changed the title Feat/guide add quality profiles and cf groups info to contributing.md feat(guide): Add quality-profile and cf-groups info to CONTRIBUTING.md Feb 10, 2025
Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:2d1253c66d98f485b3e5f6bb80f95b78e03dcb69
Status: ✅  Deploy successful!
Preview URL:https://8a230618.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2272.trash-guides-6xu.pages.dev

Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:c7aba1b54cb150a18bae06afad06541bd9f784a7
Status: ✅  Deploy successful!
Preview URL:https://1c8f1363.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2272.trash-guides-6xu.pages.dev

218-219: Wrong amount of left-padding spaces(want multiple of 4)
221: Wrong amount of left-padding spaces(want multiple of 4)
223-227: Wrong amount of left-padding spaces(want multiple of 4)
284: Wrong amount of left-padding spaces(want multiple of 4)
286: Wrong amount of left-padding spaces(want multiple of 4)
@TRaSH- TRaSH- merged commit 519d137 into master Feb 10, 2025
9 checks passed
@TRaSH- TRaSH- deleted the feat/guide-add-quality-profiles-and-cf-groups-info-to-contributing.md branch February 10, 2025 21:23
Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:9fc539c577c55fc9ca348bba65489ac141a6cbb6
Status: ✅  Deploy successful!
Preview URL:https://58024ec9.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2272.trash-guides-6xu.pages.dev

SeiyaGame pushed a commit to SeiyaGame/Guides that referenced this pull request Feb 16, 2025
…ING.md` (TRaSH-Guides#2272)

* Update CONTRIBUTING.md

Started adding info about
- quality-profiles
- cf-groups

* Fixed: several MD errors

* fix: 210-220: Wrong amount of left-padding spaces(want multiple of 4)

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Try: 990 Wrong amount of left-padding spaces(want multiple of 4)

218-219: Wrong amount of left-padding spaces(want multiple of 4)
221: Wrong amount of left-padding spaces(want multiple of 4)
223-227: Wrong amount of left-padding spaces(want multiple of 4)
284: Wrong amount of left-padding spaces(want multiple of 4)
286: Wrong amount of left-padding spaces(want multiple of 4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant