Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(guide): Add basic information for how Custom Format scoring works #2294

Merged
merged 3 commits into from
Feb 22, 2025
Merged

feat(guide): Add basic information for how Custom Format scoring works #2294

merged 3 commits into from
Feb 22, 2025

Conversation

yammes08
Copy link
Contributor

Pull Request

Purpose

Add basic information for how Custom Format scoring works
Closes #2176

Approach

  • Created new Custom Format Scoring info includes for Radarr and Sonarr
  • Added new Custom Format Scoring info includes to info sections for Radarr and Sonarr

Open Questions and Pre-Merge TODOs

Requirements

@yammes08
- Created new Custom Format Scoring info includes for Radarr and Sonarr
d6a28f9 
- Added new Custom Format Scoring info includes to info sections for Radarr and Sonarr
@yammes08 yammes08 added Status: Confirmed The issue has been confirmed Type: Enhancement Feature Request or Improvement of suboptimal status quo Status: Review Needed Ready for Review Area: Sonarr Sonarr Related Area: Radarr Radarr Related Type: Guide Request Requested new guide or enhancements to guide labels Feb 22, 2025
@yammes08 yammes08 self-assigned this Feb 22, 2025
@yammes08 yammes08 requested a review from a team February 22, 2025 12:47
@github-actions github-actions bot added the Area: Backend Backend Changes, not related to a specific section label Feb 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

@yammes08 your pull request title "feat(guides): Add basic information for how Custom Format scoring works" does not conform to our naming conventions.

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci(<area>): <description>

You can check your title at this regex101 link."

@yammes08 yammes08 changed the title feat(guides): Add basic information for how Custom Format scoring works feat: Add basic information for how Custom Format scoring works Feb 22, 2025
@yammes08 yammes08 changed the title feat: Add basic information for how Custom Format scoring works feat(guide): Add basic information for how Custom Format scoring works Feb 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:d6a28f9828343c15224a752dbe95ad47c4d1a243
Status: ✅  Deploy successful!
Preview URL:https://3e8877a9.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2294.trash-guides-6xu.pages.dev

@github-actions GitHub Actions
Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:62ae54fb197d86101240554687f4331f11e56c9e
Status: ✅  Deploy successful!
Preview URL:https://bb5bb4c2.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2294.trash-guides-6xu.pages.dev

@nuxencs
Copy link
Contributor

nuxencs commented Feb 22, 2025

wouldn't a centralized markdown file make more sense instead of 2 separate ones for Sonarr and Radarr? 🤔

@yammes08
Copy link
Contributor Author

wouldn't a centralized markdown file make more sense instead of 2 separate ones for Sonarr and Radarr? 🤔

I did it this way because I couldn't find a central includes location. I suppose I could make one...

@bakerboy448
Copy link
Contributor

If we do that then there's existing we should reorg.

Think typically it goes to one and then just included x-over?

@yammes08
Created new shared includes folder
149ee5b 
Updated changed pages to use single shared include
@yammes08
Copy link
Contributor Author

yammes08 commented Feb 22, 2025 •
edited
Loading

If we do that then there's existing we should reorg.

Think typically it goes to one and then just included x-over?

I've set up a 'shared' folder, and relinked this PR's changes to that instead. We can take forward a future activity to look for other candidates to go here.

@github-actions GitHub Actions
Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:149ee5b5c6ff26925fdefc66fa145cdb50d733a7
Status: ✅  Deploy successful!
Preview URL:https://adc74e47.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2294.trash-guides-6xu.pages.dev

nuxencs
nuxencs approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@nuxencs nuxencs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yammes08 yammes08 merged commit 0c90e21 into master Feb 22, 2025
9 checks passed
@yammes08 yammes08 deleted the feat/add-CF-scoring-basics branch February 22, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuxencs nuxencs nuxencs approved these changes

Assignees

@yammes08 yammes08

Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Status: Confirmed The issue has been confirmed Status: Review Needed Ready for Review Type: Enhancement Feature Request or Improvement of suboptimal status quo Type: Guide Request Requested new guide or enhancements to guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(guide): basics how scoring works for the CF
3 participants
@yammes08 @nuxencs @bakerboy448