Upload Progress Bar #1502
Open
Upload Progress Bar #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karjo24
requested changes
Mar 4, 2025
| <li>Presentation Video: <b x-text="progress.PRES === null ? 'skipped' : `${progress.PRES}%`"></b></li> | ||
| <li>Camera Video: <b x-text="progress.CAM === null ? 'skipped' : `${progress.CAM}%`"></b></li> | ||
| <li>Combined Video: | ||
| <div x-data="{ currentVal: progress.COMB, minVal: 0, maxVal: 100 }" class="flex h-4 w-full overflow-hidden rounded-radius bg-surface-alt dark:bg-surface-dark-alt" role="progressbar" aria-label="default progress bar" :aria-valuenow="currentVal" :aria-valuemin="minVal" :aria-valuemax="maxVal"> |
There was a problem hiding this comment.
The documentation recommends to use the native element whenever possible. If this is possible and doesn't overcomplicate things, we should probably follow this advice.
If we keep the role, we can leave out the :aria-valuemin="minVal" :aria-valuemax="maxVal" as this defaults to 0 and 100 respectively.
| </div> | ||
| </li> | ||
| <li>Presentation Video: | ||
| <div x-data="{ currentVal: progress.PRES, minVal: 0, maxVal: 100 }" class="flex h-4 w-full overflow-hidden rounded-radius bg-surface-alt dark:bg-surface-dark-alt" role="progressbar" aria-label="default progress bar" :aria-valuenow="currentVal" :aria-valuemin="minVal" :aria-valuemax="maxVal"> |
| </div> | ||
| </li> | ||
| <li>Camera Video: | ||
| <div x-data="{ currentVal: progress.CAM, minVal: 0, maxVal: 100 }" class="flex h-4 w-full overflow-hidden rounded-radius bg-surface-alt dark:bg-surface-dark-alt" role="progressbar" aria-label="default progress bar" :aria-valuenow="currentVal" :aria-valuemin="minVal" :aria-valuemax="maxVal"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fixes issue #1213
Description
added a progress bar for the upload of videos in the admin panel
Steps for Testing
Prerequisites:
Screenshots