Update paths #768
Update paths #768
Conversation
|
@Alagts thanks a lot for your suggestion. it seems like you based you pull request on branch 12.4 and then made your pull request on branch main This causes many unrelated commits to be in your pull request and conflicst. Please rebase your branch on main or cherry pick your changes into a new change based on branch main. If you need help doing that, please tell us |
|
|
||
| The TCA definition of a new table with the name "database-table-name" must be done in the | ||
| extension directory :file:`Configuration/TCA/` with :file:`database-table-name.php` as filename. | ||
| An example is :file:`EXT:sys_note/Configuration/TCA/sys_note.php` for table "sys_note". This file will be | ||
| An example is :file:`EXT:cms-sys_note/Configuration/TCA/sys_note.php` for table "sys_note". This file will be |
There was a problem hiding this comment.
| An example is :file:`EXT:cms-sys_note/Configuration/TCA/sys_note.php` for table "sys_note". This file will be | |
| An example is :file:`EXT:sys_note/Configuration/TCA/sys_note.php` for table "sys_note". This file will be |
The extension is still called sys_note
There was a problem hiding this comment.
Ah, this was not clear to me. I thought that the name of the extension and the path in the project is the same.
There was a problem hiding this comment.
@Alagts Your assumption is partly correct - however, only for a non composer (lagacy) installation (typo3conf/ext/<extension-key> => EXT:<extension-key>
That differs from a composer package name (vendor/package-name ) which needs to hav a extra => typo3/cms => extension-key set to define the extension name. Since v12 extension are no longer installed to typo3conf/ext/<extension-key> and left in vendor/<vendor>/<package-name> (instead of the extension key name). Assets are not symliked by name, but by hash etc.
;)
| @@ -54,15 +54,15 @@ to existing tables and add new tables. Several required extensions that are | |||
| always loaded, already deliver some TCA files in their | |||
| :file:`Configuration/TCA` directories. | |||
|
|
|||
| Most importantly, the extension "core" comes with a definition of pages, | |||
| Most importantly, the extension "cms-core" comes with a definition of pages, | |||
There was a problem hiding this comment.
| Most importantly, the extension "cms-core" comes with a definition of pages, | |
| Most importantly, the extension "core" comes with a definition of pages, |
The extension ist still called core
| The extension "frontend" comes with the tables tt_content, fe_users, sys_template and more. | ||
| See the directories :file:`typo3/sysext/core/Configuration/TCA/` and | ||
| :file:`typo3/sysext/frontend/Configuration/TCA/` for the complete list of the TYPO3 CMS tables. | ||
| The extension "cms-frontend" comes with the tables tt_content, fe_users, sys_template and more. |
There was a problem hiding this comment.
| The extension "cms-frontend" comes with the tables tt_content, fe_users, sys_template and more. | |
| The extension "frontend" comes with the tables tt_content, fe_users, sys_template and more. |
| :file:`typo3/sysext/frontend/Configuration/TCA/` for the complete list of the TYPO3 CMS tables. | ||
| The extension "cms-frontend" comes with the tables tt_content, fe_users, sys_template and more. | ||
| See the directories :file:`vendor/typo3/cms-core/Configuration/TCA/` and | ||
| :file:`vendor/typo3/cms-frontend/Configuration/TCA/` for the complete list of the TYPO3 CMS tables. |
There was a problem hiding this comment.
This is however only true for composer-based installations
There was a problem hiding this comment.
Ok but still most people hopefully use the Composer based setup.
Anyhow if I have seen correctly mostly everything I said was not right. You can therefore skip the pull request. Or we write explicitly that this path only is valid in Composer based installations. I don't know more what to add to your comment.
There was a problem hiding this comment.
hopefully use the Composer based setup.
@Alagts Sadly, no. Taken the latest statistics, it's ~47% between composer and non-composer installations for v11 and v12
See: https://www.t3versions.com/statistics-detail/21 (:heart: thanks to @derhansen )
|
How to proceed here? This PR is still trying to merge into 12.4, not main (which Lina already pointed out above). Also, there are several suggested changes which basically undo the patch. I suggest to close. If someone sees a possibility to salvage this, please repoen. @Alagts Sorry about this. Sometimes things get merged right away, sometimes changes are requested, and sometimes a PR is rejected. If you have any questions, need help or motivation, you can use the TYPO3 Slack channel |
I updated the paths to the new directory structure