Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Sanitize identifiers created client side #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lolli42
Copy link
Contributor

@lolli42 lolli42 commented Apr 8, 2019

Affects createFolderAction(), fileExistsAction(), fileUploadAction()

Affects createFolderAction(), fileExistsAction(), fileUploadAction()
Copy link
Collaborator

@juergen-venne juergen-venne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

– using identifier of existing file returns the expected file entity, as expected.
but
– using the same identifier with storage id changed to a non existent storage 2: the returned JSON is 200: {"state": 1}
– using the same identifier with changed foldername to a non-existing folder the returned JSON is 200: {"state": 1}
– using identifier of non existing file returns 200:{"state": 0}
Is that the expected behavior?

@lolli42
Copy link
Contributor Author

lolli42 commented Apr 9, 2019

@juergen-venne yes. the api does not throw different error messages between 'no such storage' and 'no such folder'. there is no need to change this until it is really needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants