[BUGFIX] Harden SearchRequest against array get parameters #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass filters or the q parameter as arrays like this: https://www.example.com/search/?search[filter][0][]=type:News&search[q][]=nhsi4k1z It will trigger a TYPO3 Exception like this: Uncaught TYPO3 Exception: #1476107295: PHP Warning: trim() expects parameter 1 to be string, array given in /path/private/typo3conf/ext/solr/Classes/Domain/Search/SearchRequest.php line 562 This change adds a few checks to handle that case
dkd-kaehm
requested changes
Oct 15, 2021
dkd-kaehm
force-pushed
the
main
branch
3 times, most recently
from
363e234 to
a9bae2f
Compare
dkd-kaehm
force-pushed
the
main
branch
2 times, most recently
from
e865edc to
89d9f0d
Compare
dkd-kaehm
force-pushed
the
main
branch
2 times, most recently
from
16bf8c5 to
dfcdd98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass filters or the q parameter as arrays like this:
https://www.example.com/search/?search[filter][0][]=type:News&search[q][]=nhsi4k1z
It will trigger a TYPO3 Exception like this:
Uncaught TYPO3 Exception: #1476107295: PHP Warning: trim() expects parameter 1 to be string, array given in /path/private/typo3conf/ext/solr/Classes/Domain/Search/SearchRequest.php line 562
This change adds a few checks to handle that case
Fixes: #3062