[BUGFIX] slow response when allowedSites = __all #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netcoop
force-pushed
the
bugfix/3292-fix-slow-allowedSites-all
branch
3 times, most recently
from
398b9e6 to
91d16c6
Compare
dkd-kaehm
force-pushed
the
bugfix/3292-fix-slow-allowedSites-all
branch
from
91d16c6 to
d8bcdb3
Compare
dkd-kaehm
requested changes
Sep 9, 2022
There was a problem hiding this comment.
@netcoop
Thanks for fixing that and sorry for late response.
IMHO the single usage of getDomainListOfAllSites() method is on search context, where TypoScript and other stuff from all sites is not required.
It requires just the domain of each site to be able to generate the site-hash for filter query like
siteHash:abcde OR siteHash:edcba OR ... ignoring the configuration state of solr on each site.
Therefore i would suggest to adjust the test case to the new scenario suggested by you.
Besides that, please add following in your commit message:
Fixes: #3292
Relates: #2655
`
363e234 to
a9bae2f
Compare
dkd-kaehm
force-pushed
the
main
branch
2 times, most recently
from
e865edc to
89d9f0d
Compare
dkd-kaehm
force-pushed
the
main
branch
2 times, most recently
from
16bf8c5 to
dfcdd98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Fixes very slow response when search.query.allowedSites = __all, esp. on multi-site installations.
How to test
Add a couple of extra sites with their own domain or subdomain and measure the time it takes for the method getDomainListOfAllSites to complete. Without the patch, this could easily run up to 0.3 or 0.5 seconds for each domain. With this fix, the time is negligible (and so it should, because this method is process uncached).
Fixes: #3292