Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Handle if some tags are upper-case and strict-comparison #3941

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

thomashohn
Copy link
Contributor

@thomashohn thomashohn commented Jan 31, 2024

What this pr does

Make take content case-in sensitive to running it by strtolower

How to test

Have content like foo in the DB

Fixes: #3940

The method getTagContent in class HtmlContentExtractor should also for
work for tags that are not lower case.

Resolves: TYPO3-Solr#3940
dkd-friedrich pushed a commit to dkd-friedrich/ext-solr that referenced this pull request Feb 23, 2024
The method getTagContent in class HtmlContentExtractor should also for
work for tags that are not lower case.

Ports: TYPO3-Solr#3941
Resolves: TYPO3-Solr#3940
Copy link
Member

@dkd-friedrich dkd-friedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkd-friedrich dkd-friedrich merged commit 6254379 into TYPO3-Solr:main Feb 23, 2024
8 checks passed
dkd-friedrich pushed a commit that referenced this pull request Feb 23, 2024
The method getTagContent in class HtmlContentExtractor should also for
work for tags that are not lower case.

Ports: #3941
Resolves: #3940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Function getTagContent should be case insensitive
2 participants