Skip to content

Commit

Permalink
[TASK] Adjust interface type hint to match current implementation (#1016
Browse files Browse the repository at this point in the history
)

Currently, the actual View instance in fact doesn't always return
a string for `render()`. We should change this in the future, but
for now the interface should represent the actual
implementation.
  • Loading branch information
s2b authored Nov 18, 2024
1 parent 5c9a472 commit 5ecd828
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/View/TemplateAwareViewInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@
* Optional addition to ViewInterface if the view deals with template files.
*
* @api
* @todo add return types with Fluid v5
*/
interface TemplateAwareViewInterface
{
/**
* @todo as the outfacing interface, this (and its implementations) should actually return a string
* @param string $templateName A template name to render, e.g. "Main/Index"
* @return string The rendered view
* @return mixed The rendered view
* @api
*/
public function render(string $templateName = '');
Expand Down

0 comments on commit 5ecd828

Please sign in to comment.