Phpstan v2 #1017
Merged
Phpstan v2 #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> composer req --dev phpstan/phpstan:^2.0.2 phpstan/phpstan-phpunit:^2.0.1 > vendor/bin/phpstan analyze --generate-baseline
Some tests verify if view helper classes are an instance of an abstract to see if the VH "can be instantiated". Those are useless and instantiation of those VH's is indirectly tested by following tests that render a template using the VH. The instanceof tests add no value and are removed, testing for the abstracts is useless anyway and the only contract that must be adhered to is ViewHelperInterface, which is tested by the following tests.
Instead of a dummy assertion.
SimpleFileCache->getCachedFilenames() always returns an array.
phpstan is correct here, the is_array() check is obsolete since the variable is initialized as array and preg_match_all() won't change its type when hand over as reference.
If setCache() has not been called, the property is null. Reflect this in the type annotation.
In RenderingContext: Property $errorHandler can be null if setErrorHandler() has not been called. Reflect this in the type annotation.
implode() always returns string, $actualViewHelperClassName can never be false.
There is no point in calling parent::initializeArguments() when we know the parent method is an empty dummy method that will most likely never have a body since that would break too much.
s2b
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.