TASK: Fix phpstan error

TYPO3 · May 24, 2023 · 8b426c7 · 8b426c7
1 parent 343835f
commit 8b426c7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -4,8 +4,3 @@ parameters:
 			message: "#^Instantiated class ProjectServiceContainer not found\\.$#"
 			count: 1
 			path: src/Cli/Symfony/ConsoleKernel.php
-
-		-
-			message: "#^Parameter \\#2 \\$node of method TYPO3\\\\Surf\\\\Domain\\\\Service\\\\ShellCommandService\\:\\:executeOrSimulate\\(\\) expects TYPO3\\\\Surf\\\\Domain\\\\Model\\\\Node, TYPO3\\\\Surf\\\\Domain\\\\Model\\\\Node\\|null given\\.$#"
-			count: 1
-			path: src/Task/TYPO3/CMS/AbstractCliTask.php
diff --git a/src/Task/TYPO3/CMS/AbstractCliTask.php b/src/Task/TYPO3/CMS/AbstractCliTask.php
@@ -50,7 +50,7 @@ protected function executeCliCommand(array $cliArguments, Node $node, CMS $appli
         }
         $commandPrefix .= $phpBinaryPathAndFilename . ' ';
 
-        if (!$this->targetNode instanceof Node) {
+        if ($this->targetNode === null) {
             return false;
         }
 
@@ -121,6 +121,10 @@ protected function fileExists(string $pathAndFileName, Node $node, CMS $applicat
         $this->determineWorkingDirectoryAndTargetNode($node, $application, $deployment, $options);
         $pathAndFileName = $this->workingDirectory . '/' . $pathAndFileName;
 
+        if ($this->targetNode === null) {
+            return false;
+        }
+
         return $this->shell->executeOrSimulate('test -f ' . escapeshellarg($pathAndFileName), $this->targetNode, $deployment, true) !== false;
     }
 }