[BUGFIX] Harden XPath query to limit search for page tree node

[eliashaeussler]

Even if page tree nodes are queried from a given context node, the currently used XPath query searches for all elements in the document instead. That's because of the // syntax, which searches in the whole document, regardless of which context is given. This may lead to possible test failures in case the queried node text appears multiple times in the document, for example when trying to access the root page tree node whose text appears twice on the page – next to the TYPO3 logo in the topbar and as root node in the page tree. With the current implementation, the XPath query would match the text in the topbar instead of the text of the root node.

In order to avoid such behaviors and actually limit the XPath query to the given context, it is now prefixed with a dot (.). In addition, only following siblings of the current node are included since page tree nodes are presented as flat node structure. This way, the current context is now actually taken into account.

As an additional fix, property accesses of static properties in AbstractPageTree is now changed from self:: to static:: to properly respect overridden properties in extended classes. This is especially necessary for the overridden properties in TYPO3 core's FileTree.

Patch in TYPO3 core: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80039

💡 If this PR will be merged, I'll update the TYPO3 core patch accordingly.

[oliverklee]

As an additional fix, property accesses of static properties in AbstractPageTree is now changed from self:: to static:: to properly respect overridden properties in extended classes. This is especially necessary for the overridden properties in TYPO3 core's FileTree.

I propose we move this to a separate change (following the "only one kind of change per PR" rule).

[eliashaeussler]

As an additional fix, property accesses of static properties in AbstractPageTree is now changed from self:: to static:: to properly respect overridden properties in extended classes. This is especially necessary for the overridden properties in TYPO3 core's FileTree.

I propose we move this to a separate change (following the "only one kind of change per PR" rule).

Sure, we can do that.

The reason why I combined both changes into one PR is because the change of the XPath query makes tests in TYPO3 core fail due to the fact those static properties are not accessed correctly. This additional change was necessary to make tests in https://review.typo3.org/c/Packages/TYPO3.CMS/+/80039 green again 😉

But I'm also totally fine with splitting into two separate PRs.

[sbuerk]

@eliashaeussler Don't act for now !!!

In TF we usually do not merge it as merge-commits, so as long as we
have dedicated commits for each thing it may be okay. Not qualified
reviewed it yet, will do this later.

The comment from @oliverklee in general is valid and a good advice
generally (makes it possible to merge one thing and eventually
continue on the rest).

In the worst case we (I) would cherry-pick the commits anyway.

Only point on quick view, it would be nice to have one or to sentence
in the commit message for 9f47062.

[eliashaeussler]

@sbuerk Do you need anything else from me to continue here? :)

[lolli42]

Ok. We now extracted the 'static' change with #625 to an own PR. Core tests stay green with this one for now, so we can reduce the PR a bit already without a core cross-dependency.

[lolli42]

Ok, seems we're done here:

See #625
See #626

We cherry-picked the two (well split) commits to new PR's, of course keeping your authorship!
As such, we can close this PR now.
Sorry for the massive delay on this one, thes delay is not what we aim for.
Your two changes are done now, and we think it's a good improvement.
Thank you!

[eliashaeussler]

@lolli42 Thanks for taking care!