[TASK] Replace \PDO::PARAM_* constants with Connection::PARAM_*
#514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces the `\PDO::PARAM_*` constants with the TYPO3
`\TYPO3\CMS\Core\Database\Connection::PARAM_*` alternatives. This
aligns the testing-framework with the core and the communicated
best-practice.
The direct dependency to `ext-pdo` is removed right away.
Note: `doctrine/dbal 4+` dropps support for the \PDO integer constants.
Using the `Connection` constants allows us to change the mapping
in that class and consuming code, like extensions or this package
automaticlly uses the correct enum class on upgrade.
Used command(s):
```shell
composer remove ext-pdo
```
Releases: main, 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the
\PDO::PARAM_*constants with the TYPO3\TYPO3\CMS\Core\Database\Connection::PARAM_*alternatives. Thisaligns the testing-framework with the core and the communicated
best-practice.
The direct dependency to
ext-pdois removed right away.Note:
doctrine/dbal 4+dropps support for the \PDO integer constants.Using the
Connectionconstants allows us to change the mappingin that class and consuming code, like extensions or this package
automaticlly uses the correct enum class on upgrade.
Used command(s):
Releases: main, 7