Skip to content

Commit

Permalink
[TASK] Stop storing development tool PHARs in the repository (#1277)
Browse files Browse the repository at this point in the history
Tools that are downloadable should in general be downloaded during
the CI runs, not stored in the repository.

As the only PHIVE PHAR we're using is PCOV (for code coverage, which
we usually only run on CI), we can skip providing PHIVE and rely on
CI to provide PHIVE for us. This leaves only PCOV to be installed
via PHIVE.

Fixes #267
  • Loading branch information
oliverklee authored May 7, 2024
1 parent 1a0a288 commit 188303f
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 94,923 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/codecoverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ jobs:
extensions: mysqli
coverage: pcov
ini-values: pcov.directory=Classes
- name: "Install development tools"
run: phive --no-progress install --trust-gpg-keys D8406D0D82947747293778314AA394086372C20A
- name: "Show Composer version"
run: composer --version
- name: "Show the Composer configuration"
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
- Add support for PostgreSQL 16 (#1271)

### Changed
- Stop storing development tool PHARs in the repository (#1277)
- !!! Require a storage PID for the tea list (#1223)
- Drop additional namespace segment for the Tea model (#1025)

Expand Down
3 changes: 1 addition & 2 deletions phive.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<phive xmlns="https://phar.io/phive">
<phar name="phar-io/phive" version="^0.15.2" installed="0.15.2" location="./tools/phive" copy="true"/>
<phar name="phpcov" version="^8.2.1" installed="8.2.1" location="./tools/phpcov" copy="true"/>
<phar name="phpcov" version="^8.2.1" installed="8.2.1" location="./tools/phpcov" copy="false"/>
</phive>
Loading

0 comments on commit 188303f

Please sign in to comment.