Skip to content

Commit

Permalink
[TASK] Switch to the Coveralls GitHub action
Browse files Browse the repository at this point in the history
Unfortunately, with the GitHub Action, we need to go back to
using the path `build/logs/clover.xml` for the combined coverage file.

Closes #1431
  • Loading branch information
oliverklee committed Aug 23, 2024
1 parent 9005c3c commit 34c4d73
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/codecoverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,13 @@ jobs:
run: "ls -lahR .Build/coverage/"
- name: "Merge coverage results"
run: composer ci:coverage:merge
- name: "Show generated coverage files"
run: "ls -lahR .Build/coverage/"
- name: "Show combined coverage files"
run: "ls -lahR build/logs/"
- name: "Upload coverage results to Coveralls"
uses: coverallsapp/github-action@v2
env:
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: .Build/bin/php-coveralls --coverage_clover=.Build/coverage/combined.xml --json_path=.Build/coverage/coveralls-upload.json -v
github-token: ${{ secrets.GITHUB_TOKEN }}
file: build/logs/clover.xml
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/.php-cs-fixer.cache
/.phpunit.result.cache
/Documentation-GENERATED-temp/
/clover.xml
/build
/composer.lock
/generate-documentation.sh
/nbproject
Expand Down
5 changes: 2 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"friendsofphp/php-cs-fixer": "^3.62.0",
"helmich/typo3-typoscript-lint": "^3.1.1",
"icanhazstring/composer-unused": "^0.8.11",
"php-coveralls/php-coveralls": "^2.7.0",
"php-parallel-lint/php-parallel-lint": "^1.4",
"phpmd/phpmd": "^2.15.0",
"phpstan/extension-installer": "^1.4.1",
Expand Down Expand Up @@ -132,7 +131,7 @@
],
"ci:coverage:merge": [
"@coverage:create-directories",
"@php tools/phpcov merge --clover=.Build/coverage/combined.xml .Build/coverage/"
"@php tools/phpcov merge --clover=build/logs/clover.xml .Build/coverage/"
],
"ci:coverage:unit": [
"@coverage:create-directories",
Expand Down Expand Up @@ -170,7 +169,7 @@
"ci:typoscript:lint": "typoscript-lint -c Configuration/TsLint.yml --ansi -n --fail-on-warnings -vvv Configuration/TypoScript",
"ci:xliff:lint": "php Build/xliff/xliff-lint lint:xliff Resources/Private/Language",
"ci:yaml:lint": "find . ! -path '*.Build/*' ! -path '*node_modules/*' \\( -name '*.yaml' -o -name '*.yml' \\) | xargs -r php ./.Build/bin/yaml-lint",
"coverage:create-directories": "mkdir -p .Build/coverage",
"coverage:create-directories": "mkdir -p .Build/coverage build/logs",
"docs:generate": "docker run --rm --pull always -v $(pwd):/project -it ghcr.io/typo3-documentation/render-guides:latest --config=Documentation",
"fix:composer:normalize": "@composer normalize --no-check-lock",
"fix:php": [
Expand Down

0 comments on commit 34c4d73

Please sign in to comment.