Fix default value of Tea::internalNotes and add tests

TYPO3BestPractices · Aug 26, 2021 · 429f24c · 429f24c
1 parent b025689
commit 429f24c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/Classes/Domain/Model/Product/Tea.php b/Classes/Domain/Model/Product/Tea.php
@@ -29,7 +29,7 @@ class Tea extends AbstractEntity
     /**
      * @var string
      */
-    private string $internalNotes;
+    private string $internalNotes = '';
 
     /**
      * @var \TYPO3\CMS\Extbase\Domain\Model\FileReference

diff --git a/Tests/Unit/Domain/Model/Product/TeaTest.php b/Tests/Unit/Domain/Model/Product/TeaTest.php
@@ -72,6 +72,26 @@ public function setDescriptionSetsDescription(): void
         self::assertSame($value, $this->subject->getDescription());
     }
 
+    /**
+     * @test
+     */
+    public function getInternalNotesInitiallyEmptyString(): void
+    {
+        self::assertSame('', $this->subject->getInternalNotes());
+    }
+
+    /**
+     * @test
+     */
+    public function setInternalNotesSetsInternalNotes(): void
+    {
+        $notes = 'Yery yummy! Buy lots of this!';
+
+        $this->subject->setInternalNotes($notes);
+
+        self::assertSame($notes, $this->subject->getInternalNotes());
+    }
+
     /**
      * @test
      */