[CLEANUP] Use more stubs instead of mocks (#995)

This makes the purpose of the test doubles more clear to the reader. Fixes #986
TYPO3BestPractices · Nov 18, 2023 · 4509052 · 4509052
1 parent 3cdf8df
commit 4509052
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Tests/Unit/Controller/FrontEndEditorControllerTest.php b/Tests/Unit/Controller/FrontEndEditorControllerTest.php
@@ -114,7 +114,7 @@ public function indexActionForLoggedInUserAssignsTeasOwnedByTheLoggedInUserToVie
         $userUid = 5;
         $this->setUidOfLoggedInUser($userUid);
 
-        $teas = $this->createMock(QueryResultInterface::class);
+        $teas = $this->createStub(QueryResultInterface::class);
         $this->teaRepositoryMock->method('findByOwnerUid')->with($userUid)->willReturn($teas);
         $this->viewMock->expects(self::once())->method('assign')->with('teas', $teas);
 

diff --git a/Tests/Unit/Controller/TeaControllerTest.php b/Tests/Unit/Controller/TeaControllerTest.php
@@ -68,7 +68,7 @@ public function isActionController(): void
      */
     public function indexActionAssignsAllTeaAsTeasToView(): void
     {
-        $teas = $this->createMock(QueryResultInterface::class);
+        $teas = $this->createStub(QueryResultInterface::class);
         $this->teaRepositoryMock->method('findAll')->willReturn($teas);
         $this->viewMock->expects(self::once())->method('assign')->with('teas', $teas);