Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dutch translation #1023

Conversation

frschep
Copy link

@frschep frschep commented Nov 27, 2023

No description provided.

Copy link
Contributor

@lukaszuznanski lukaszuznanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you should leave in every file in order to make this work correctly.

@oliverklee oliverklee added the enhancement New feature or request label Nov 27, 2023
@oliverklee oliverklee added this to the Codesprint 2023-11-27 milestone Nov 27, 2023
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first PR!

Could you also please add a changelog entry for this (newest on top, using the PR ID)? Thanks!

<header/>
<body>
<trans-unit id="plugin.tea_index">
<source>Theelijst</source>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NL localization needs to be in the <target> nodes, while the original EN text needs to be in the <source> nodes.

Also, the target language needs to be referenced in the file header. Please have a look at the DE and PL localization files for this.

@frschep frschep closed this Nov 27, 2023
@frschep frschep deleted the provideDutchTranslationForTheTeaExtension-1016 branch November 27, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants