[!!!][TASK] Drop additional namespace segment for the Tea model #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
force-pushed
the
task/drop-product-namespace
branch
from
aae435a to
5148e10
Compare
Pull Request Test Coverage Report for Build 7006769465
💛 - Coveralls |
oliverklee
requested review from
lukaszuznanski,
DanielSiepmann,
Starkmann,
kanow and
frschep
oliverklee
force-pushed
the
task/drop-product-namespace
branch
from
5148e10 to
6c8afe6
Compare
Yes, makes sense. I've moved this to the 4.0 milestone now. |
oliverklee
force-pushed
the
task/drop-product-namespace
branch
2 times, most recently
from
fc7a406 to
d9576f8
Compare
oliverklee
force-pushed
the
task/drop-product-namespace
branch
2 times, most recently
from
7f6b8f8 to
58baae1
Compare
oliverklee
force-pushed
the
task/drop-product-namespace
branch
from
58baae1 to
a837493
Compare
oliverklee
force-pushed
the
task/drop-product-namespace
branch
from
a837493 to
585104b
Compare
oliverklee
force-pushed
the
task/drop-product-namespace
branch
from
585104b to
90db6d8
Compare
oliverklee
force-pushed
the
task/drop-product-namespace
branch
from
90db6d8 to
8d4d45a
Compare
|
@DanielSiepmann @lukaszuznanski ping for a review - thanks! |
lukaszuznanski
approved these changes
Jan 16, 2024
I don't think this would we worth the effort in this case: Any data is test data anyway, and instead of migrating data, I'd prefer to have a script/command create the test data: #1120 |
The `Product` namespace segment in the domain model namespace `TTN\Tea\Domain\Model` currently serves no purpose and only adds confusion. So let's simplify the extension structure accordingly. (I intended to use this to demonstrate DDD contexts, but never built enough models in the Tea extension for this to actually make sense.) Fixes #1008
oliverklee
force-pushed
the
task/drop-product-namespace
branch
from
8d4d45a to
572cd62
Compare
|
Data is not affected anyway, so not a showcase for how to add UpgradeWizards anyway. This would only be an opportunity to provide a rector rule. But I also won't think we should do that right now. |
DanielSiepmann
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Productnamespace segment in the domain model namespaceTTN\Tea\Domain\Modelcurrently serves no purpose and only adds confusion. So let's simplify the extension structure accordingly.(I intended to use this to demonstrate DDD contexts, but never built enough models in the Tea extension for this to actually make sense.)
Fixes #1008