Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Remove invalid argument quoting in runTests.sh #1029

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[BUGFIX] Remove invalid argument quoting in runTests.sh #1029

merged 1 commit into from
Nov 27, 2023

Conversation

sbuerk
Copy link
Contributor

@sbuerk sbuerk commented Nov 27, 2023

Build/Scripts/runTests.sh provides a test-suite
composer and allows passing additional command
and options directly down to the composer command.

Due to an invalid quoting the passed options were
broking and not regonized by the composer binary.

This change removes the superflous argument passing
and therefore allows passing additional options to
the composer command.

Resolves: #967

`Build/Scripts/runTests.sh` provides a test-suite `composer`
and allows passing additional command and options directly
down to the composer command.

Due to an invalid quoting the passed options were broking
and not regonized by the `composer` binary.

This change removes the superflous argument passing
and therefore allows passing additional options to the
`composer` command.

Resolves: #967
@oliverklee oliverklee added the bug Something isn't working label Nov 27, 2023
@oliverklee oliverklee added this to the Codesprint 2023-11-27 milestone Nov 27, 2023
@oliverklee oliverklee changed the title [BUGFIX] Remove invalid argument quuoting in runTests.sh [BUGFIX] Remove invalid argument quoting in runTests.sh Nov 27, 2023
@oliverklee oliverklee enabled auto-merge (squash) November 27, 2023 15:34
@oliverklee oliverklee merged commit ba486fc into TYPO3BestPractices:main Nov 27, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working runTests.sh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run Composer with options using runTests.sh
2 participants