Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add Rector #1031

Merged
merged 8 commits into from
May 7, 2024

Conversation

Starkmann
Copy link
Collaborator

@Starkmann Starkmann commented Nov 27, 2023

This part of #851.

In later parts, we'll add a Rector wrapper to runTests.sh and a CI job, and apply possible changes suggested by Rector.

Part of #851
Closes #125

@oliverklee oliverklee changed the title [TASK] add rector [FEATURE] Add Rector Nov 27, 2023
@oliverklee oliverklee added the enhancement New feature or request label Nov 27, 2023
@oliverklee oliverklee added this to the Codesprint 2023-11-27 milestone Nov 27, 2023
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also should document somewhere (e.g., in the manual) how to run Rector via DDEV and runTests.sh.

Also, we should add the rector.php to the list of not-packaged files in .gitattributes and the prepare-release Composer script.

composer.json Outdated Show resolved Hide resolved
rector.php Show resolved Hide resolved
@lukaszuznanski
Copy link
Contributor

@Starkmann are you willing to work on this? If so, I will close my #992

@lukaszuznanski
Copy link
Contributor

Hi,

We've implemented a policy to close pull requests that have been inactive for over six months. If you're still interested in contributing and would like to continue working on this pull request, we're more than happy to keep it open.

Please take a moment to review your pull request and let us know if you'd like to proceed with it. If we don't receive a response within the next 30 days, we'll assume that you no longer wish to pursue it, and we'll proceed with closing the pull request.

Feel free to reach out if you have any questions or need further assistance.

@oliverklee oliverklee self-assigned this May 7, 2024
@oliverklee oliverklee force-pushed the feature/rector-851 branch from 2c77cd6 to e3b067a Compare May 7, 2024 12:24
@oliverklee oliverklee marked this pull request as draft May 7, 2024 12:24
@coveralls
Copy link

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 8987381816

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8987315319: 0.0%
Covered Lines: 46
Relevant Lines: 46

💛 - Coveralls

rector.php Outdated Show resolved Hide resolved
rector.php Outdated Show resolved Hide resolved
@oliverklee oliverklee force-pushed the feature/rector-851 branch from e3b067a to 8ceace2 Compare May 7, 2024 12:32
@oliverklee oliverklee requested a review from simonschaufi May 7, 2024 12:32
@oliverklee oliverklee force-pushed the feature/rector-851 branch from 8ceace2 to d0be517 Compare May 7, 2024 13:37
@oliverklee oliverklee marked this pull request as ready for review May 7, 2024 13:37
@oliverklee oliverklee force-pushed the feature/rector-851 branch 2 times, most recently from 8256924 to 856064f Compare May 7, 2024 13:40
rector.php Show resolved Hide resolved
@oliverklee oliverklee requested a review from DanielSiepmann May 7, 2024 13:46
@oliverklee oliverklee force-pushed the feature/rector-851 branch from 440cc29 to 07ad39e Compare May 7, 2024 13:50
@oliverklee oliverklee marked this pull request as draft May 7, 2024 13:51
@sbuerk
Copy link
Contributor

sbuerk commented May 7, 2024

Not sure if moving rector installation to a subfolder composer.json would be feasonable directly, as for TYPO3 v13 and rector there is a conflict regard the nikic php parser librady version (for the overall working forward to TYPO3 v13).

@oliverklee oliverklee marked this pull request as ready for review May 7, 2024 13:53
@oliverklee oliverklee requested a review from lukaszuznanski May 7, 2024 13:53
rector.php Outdated Show resolved Hide resolved
rector.php Outdated Show resolved Hide resolved
@oliverklee oliverklee marked this pull request as draft May 7, 2024 14:19
@oliverklee
Copy link
Contributor

Not sure if moving rector installation to a subfolder composer.json would be feasonable directly,

I'd prefer to do that in a separate step.

@oliverklee oliverklee marked this pull request as ready for review May 7, 2024 14:23
@oliverklee oliverklee force-pushed the feature/rector-851 branch 4 times, most recently from ce10ead to 2b97de3 Compare May 7, 2024 14:32
@oliverklee oliverklee enabled auto-merge (squash) May 7, 2024 14:34
@oliverklee oliverklee disabled auto-merge May 7, 2024 14:38
@oliverklee oliverklee force-pushed the feature/rector-851 branch from 2b97de3 to 8d174cd Compare May 7, 2024 14:39
@oliverklee oliverklee enabled auto-merge (squash) May 7, 2024 14:42
@oliverklee oliverklee disabled auto-merge May 7, 2024 14:43
@oliverklee oliverklee enabled auto-merge (squash) May 7, 2024 14:48
@oliverklee oliverklee merged commit ff4f7e3 into TYPO3BestPractices:main May 7, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate typo3-rector
7 participants