-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add Rector #1031
[FEATURE] Add Rector #1031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also should document somewhere (e.g., in the manual) how to run Rector via DDEV and runTests.sh
.
Also, we should add the rector.php
to the list of not-packaged files in .gitattributes
and the prepare-release
Composer script.
@Starkmann are you willing to work on this? If so, I will close my #992 |
Hi, We've implemented a policy to close pull requests that have been inactive for over six months. If you're still interested in contributing and would like to continue working on this pull request, we're more than happy to keep it open. Please take a moment to review your pull request and let us know if you'd like to proceed with it. If we don't receive a response within the next 30 days, we'll assume that you no longer wish to pursue it, and we'll proceed with closing the pull request. Feel free to reach out if you have any questions or need further assistance. |
2c77cd6
to
e3b067a
Compare
Pull Request Test Coverage Report for Build 8987381816Details
💛 - Coveralls |
e3b067a
to
8ceace2
Compare
8ceace2
to
d0be517
Compare
8256924
to
856064f
Compare
440cc29
to
07ad39e
Compare
Not sure if moving rector installation to a subfolder composer.json would be feasonable directly, as for TYPO3 v13 and rector there is a conflict regard the nikic php parser librady version (for the overall working forward to TYPO3 v13). |
I'd prefer to do that in a separate step. |
ce10ead
to
2b97de3
Compare
2b97de3
to
8d174cd
Compare
This part of #851.
In later parts, we'll add a Rector wrapper to
runTests.sh
and a CI job, and apply possible changes suggested by Rector.Part of #851
Closes #125