-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Add contribution guide #1044
Conversation
New PR as this branch now is within the repository, instead of my fork. It is the up to date version of previously #810 |
@sbuerk you already approved the original PR, but still I mention you as you kickstarted this topic. |
Also contains info from https://git.typo3.org/qa/internal-organization/-/issues/47 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One general remark on the style: We should either use full sentences (uppercase first letter, with a period at the end) or bullet-list-style sentences (lowercase first letter, no period at the end), but not the current mix of "uppercase first letter, but no period at the end".
Also, I propose we link the TYPO3 CoC and document that the author of a PR is responsible for rebasing it (if it doesn't get merged quickly).
We already have https://github.com/FriendsOfTYPO3/tea/blob/main/CODE_OF_CONDUCT.md, shouldn't that be enough? |
In theory, people should read both documents. In practice, I think linking from the contribution document to either |
Co-authored-by: Oliver Klee <[email protected]>
No description provided.