Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add contribution guide #1044

Merged
merged 5 commits into from
Dec 5, 2023
Merged

[TASK] Add contribution guide #1044

merged 5 commits into from
Dec 5, 2023

Conversation

DanielSiepmann
Copy link
Contributor

No description provided.

@DanielSiepmann
Copy link
Contributor Author

New PR as this branch now is within the repository, instead of my fork. It is the up to date version of previously #810

@DanielSiepmann
Copy link
Contributor Author

@sbuerk you already approved the original PR, but still I mention you as you kickstarted this topic.

@DanielSiepmann
Copy link
Contributor Author

Also contains info from https://git.typo3.org/qa/internal-organization/-/issues/47

Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One general remark on the style: We should either use full sentences (uppercase first letter, with a period at the end) or bullet-list-style sentences (lowercase first letter, no period at the end), but not the current mix of "uppercase first letter, but no period at the end".

Also, I propose we link the TYPO3 CoC and document that the author of a PR is responsible for rebasing it (if it doesn't get merged quickly).

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@DanielSiepmann
Copy link
Contributor Author

Also, I propose we link the TYPO3 CoC

We already have https://github.com/FriendsOfTYPO3/tea/blob/main/CODE_OF_CONDUCT.md, shouldn't that be enough?

@oliverklee oliverklee added the documentation Improvements or additions to documentation label Dec 5, 2023
@oliverklee oliverklee added this to the 3.1.0: New features milestone Dec 5, 2023
@oliverklee
Copy link
Contributor

We already have https://github.com/FriendsOfTYPO3/tea/blob/main/CODE_OF_CONDUCT.md, shouldn't that be enough?

In theory, people should read both documents. In practice, I think linking from the contribution document to either CODE_OF_CONDUCT.md or the TYPO3 CoC probably helps people notice it.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@oliverklee oliverklee merged commit 870261a into main Dec 5, 2023
51 checks passed
@oliverklee oliverklee deleted the 721-add-contribution-guide branch December 5, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants