-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Move php-cs-fixer to Build dir #1353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to update the .gitattributes
to no longer exclude the file anymore (as we already exclude Build/
).
a4b29b7
to
81cb617
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to adapt the prepare-release
Composer script.
81cb617
to
e2ad2f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to include the Build
folder to be processed by PHP-CS-Fixer and PHP_CodeSniffer now.
Pull Request Test Coverage Report for Build 10903393754Details
💛 - Coveralls |
8fecb3e
to
573cc0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to add Build
to the files that PHP-CS-Fixer and PHP_CodeSniffer check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to add Build/
to the list of directories that get stylechecked/fixed by PHP_CodeSniffer and PHP-CS-Fixer.
Also, could you please resolve the merge conflict?
4ff4a62
to
283b6e5
Compare
Pull Request Test Coverage Report for Build 12610855101Details
💛 - Coveralls |
Hi, We've implemented a policy to close pull requests that have been inactive for over six months. If you're still interested in contributing and would like to continue working on this pull request, we're more than happy to keep it open. Please take a moment to review your pull request and let us know if you'd like to proceed with it. If we don't receive a response within the next 30 days, we'll assume that you no longer wish to pursue it, and we'll proceed with closing the pull request. Feel free to reach out if you have any questions or need further assistance. |
283b6e5
to
80afe73
Compare
Part of: #1186