Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Move php-cs-fixer to Build dir #1353

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

lukaszuznanski
Copy link
Contributor

Part of: #1186

Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the .gitattributes to no longer exclude the file anymore (as we already exclude Build/).

composer.json Outdated Show resolved Hide resolved
@lukaszuznanski lukaszuznanski force-pushed the TASK/Move-php-cs-fixer-to-build-dir branch from a4b29b7 to 81cb617 Compare July 7, 2024 22:00
@lukaszuznanski lukaszuznanski requested a review from oliverklee July 7, 2024 22:01
@lukaszuznanski lukaszuznanski self-assigned this Jul 7, 2024
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Jul 8, 2024
composer.json Outdated Show resolved Hide resolved
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to adapt the prepare-release Composer script.

@lukaszuznanski lukaszuznanski force-pushed the TASK/Move-php-cs-fixer-to-build-dir branch from 81cb617 to e2ad2f6 Compare September 17, 2024 10:50
@oliverklee oliverklee changed the title [TASK] Move php-cs-fixer to build dir [TASK] Move php-cs-fixer to Build dir Sep 17, 2024
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to include the Build folder to be processed by PHP-CS-Fixer and PHP_CodeSniffer now.

composer.json Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 10903393754

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10903110277: 0.0%
Covered Lines: 67
Relevant Lines: 67

💛 - Coveralls

@lukaszuznanski lukaszuznanski force-pushed the TASK/Move-php-cs-fixer-to-build-dir branch from 8fecb3e to 573cc0e Compare September 17, 2024 12:49
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to add Build to the files that PHP-CS-Fixer and PHP_CodeSniffer check.

Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to add Build/ to the list of directories that get stylechecked/fixed by PHP_CodeSniffer and PHP-CS-Fixer.

Also, could you please resolve the merge conflict?

@oliverklee oliverklee force-pushed the TASK/Move-php-cs-fixer-to-build-dir branch 2 times, most recently from 4ff4a62 to 283b6e5 Compare January 4, 2025 13:27
@coveralls
Copy link

coveralls commented Jan 4, 2025

Pull Request Test Coverage Report for Build 12610855101

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12610848288: 0.0%
Covered Lines: 101
Relevant Lines: 101

💛 - Coveralls

@lukaszuznanski
Copy link
Contributor Author

Hi,

We've implemented a policy to close pull requests that have been inactive for over six months. If you're still interested in contributing and would like to continue working on this pull request, we're more than happy to keep it open.

Please take a moment to review your pull request and let us know if you'd like to proceed with it. If we don't receive a response within the next 30 days, we'll assume that you no longer wish to pursue it, and we'll proceed with closing the pull request.

Feel free to reach out if you have any questions or need further assistance.

@oliverklee oliverklee force-pushed the TASK/Move-php-cs-fixer-to-build-dir branch from 283b6e5 to 80afe73 Compare January 20, 2025 16:08
@oliverklee oliverklee enabled auto-merge (squash) January 20, 2025 16:10
@oliverklee oliverklee merged commit 61512af into main Jan 20, 2025
56 checks passed
@oliverklee oliverklee deleted the TASK/Move-php-cs-fixer-to-build-dir branch January 20, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants