Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Remove no longer needed path to binaries #1383

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[TASK] Remove no longer needed path to binaries #1383

merged 1 commit into from
Jul 30, 2024

Conversation

Starkmann
Copy link
Collaborator

No description provided.

@Starkmann Starkmann added this to the 4.0.0: Breaking changes milestone Jul 29, 2024
@Starkmann Starkmann requested a review from oliverklee July 29, 2024 16:44
@Starkmann Starkmann self-assigned this Jul 29, 2024
@coveralls
Copy link

coveralls commented Jul 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10166917799

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 10166538431: 0.0%
Covered Lines: 46
Relevant Lines: 46
💛 - Coveralls

oliverklee
oliverklee requested changes Jul 29, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
oliverklee

This comment was marked as outdated.

Sign in to view

Starkmann added a commit that referenced this pull request Jul 30, 2024
@Starkmann
[BUGFIX] pipe might need full path
1e8af98 
Resolves:  #1383
@Starkmann Starkmann force-pushed the feature/removeBinDir branch from 85deeef to 1e8af98 Compare July 30, 2024 11:43
@oliverklee oliverklee changed the title [FEATURE] Remove no longer needed path to binaries [TASK] Remove no longer needed path to binaries Jul 30, 2024
oliverklee

This comment was marked as outdated.

Sign in to view

@Starkmann Starkmann force-pushed the feature/removeBinDir branch from 1e8af98 to 0c41285 Compare July 30, 2024 17:13
@oliverklee oliverklee force-pushed the feature/removeBinDir branch 2 times, most recently from 39e9ef3 to 5b78093 Compare July 30, 2024 17:21
@oliverklee oliverklee force-pushed the feature/removeBinDir branch from 5b78093 to 97e9bac Compare July 30, 2024 17:22
@oliverklee oliverklee enabled auto-merge (squash) July 30, 2024 17:23
@oliverklee oliverklee merged commit c68c720 into main Jul 30, 2024
53 checks passed
@oliverklee oliverklee deleted the feature/removeBinDir branch July 30, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@Starkmann Starkmann

Labels
cleanup
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.
3 participants
@Starkmann @coveralls @oliverklee