Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add shellcheck to Github pipeline #1400

Merged
merged 3 commits into from
Jul 31, 2024
Merged

[FEATURE] Add shellcheck to Github pipeline #1400

merged 3 commits into from
Jul 31, 2024

Conversation

cumuru
Copy link
Contributor

@cumuru cumuru commented Jul 30, 2024

Fixes #1398

@cumuru cumuru added github_actions Pull requests that update GitHub Actions code feature labels Jul 30, 2024
@cumuru cumuru self-assigned this Jul 30, 2024
@cumuru cumuru linked an issue Jul 30, 2024 that may be closed by this pull request
Check the runTests.sh with shellcheck in GitHub actions #1398
Closed
4 tasks
@coveralls
Copy link

coveralls commented Jul 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10180376669

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 10180204346: 0.0%
Covered Lines: 46
Relevant Lines: 46
💛 - Coveralls

@oliverklee oliverklee changed the title [FEATURE] Add spellcheck to Github pipeline [FEATURE] Add shellcheck to Github pipeline Jul 30, 2024
@cumuru cumuru force-pushed the 1398-check-the-runtestssh-with-shellcheck-in-github-actions branch from 6017fe2 to 53b67d4 Compare July 30, 2024 15:07
oliverklee
oliverklee requested changes Jul 30, 2024
View reviewed changes
Build/Scripts/runTests.sh Outdated Show resolved Hide resolved
Build/Scripts/runTests.sh Outdated Show resolved Hide resolved
@cumuru cumuru added wip Work in progress and removed wip Work in progress labels Jul 30, 2024
@cumuru cumuru force-pushed the 1398-check-the-runtestssh-with-shellcheck-in-github-actions branch 3 times, most recently from 72e78db to 2e50682 Compare July 31, 2024 12:28
@cumuru cumuru force-pushed the 1398-check-the-runtestssh-with-shellcheck-in-github-actions branch from 2e50682 to ecc0eab Compare July 31, 2024 12:29
@oliverklee
Copy link
Contributor 

$ ./Build/Scripts/runTests.sh -b podman -s shellcheck
Error: short-name "koalaman/shellcheck:latest" did not resolve to an alias and no unqualified-search registries are defined in "/etc/containers/registries.conf"

oliverklee
oliverklee approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thank you!

@oliverklee oliverklee merged commit 99a2b7f into main Jul 31, 2024
55 checks passed
@oliverklee oliverklee deleted the 1398-check-the-runtestssh-with-shellcheck-in-github-actions branch July 31, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@cumuru cumuru

Labels
feature github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check the runTests.sh with shellcheck in GitHub actions
3 participants
@cumuru @coveralls @oliverklee