[TASK] Split COMMAND variable to be type strict #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10180071257Details
💛 - Coveralls |
cumuru
force-pushed
the
frozen-runtest-tackling-shellcheck-issues
branch
from
9f7fbaa to
46ca83a
Compare
oliverklee
requested changes
Jul 31, 2024
Build/Scripts/runTests.sh
Outdated
| COMMAND="npm $@" | ||
| ${CONTAINER_BIN} run ${CONTAINER_COMMON_PARAMS} --name npm-command-${SUFFIX} ${IMAGE_NODE} /bin/sh -c "${COMMAND}" | ||
| COMMAND_PARTS=(npm "$@") | ||
| ${CONTAINER_BIN} run ${CONTAINER_COMMON_PARAMS} --name npm-command-${SUFFIX} ${IMAGE_NODE} /bin/sh -c "${COMMAND_PARTS[@]}" |
There was a problem hiding this comment.
This change breaks this command:
./Build/Scripts/runTests.sh -s npm audit
There was a problem hiding this comment.
Good catch, thanks! Fixed.
cumuru
force-pushed
the
frozen-runtest-tackling-shellcheck-issues
branch
from
220f67e to
fb9d70a
Compare
oliverklee
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes spellcheck warnings in current main branch.