Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Add functional tests for showAction #1419

Merged
merged 4 commits into from
Jan 4, 2025
Merged

[TASK] Add functional tests for showAction #1419

merged 4 commits into from
Jan 4, 2025

Conversation

Starkmann
Copy link
Collaborator

@Starkmann Starkmann commented Jul 31, 2024 •
edited by oliverklee
Loading

Fixes #1228

@Starkmann Starkmann added this to the 4.0.0: Breaking changes milestone Jul 31, 2024
@Starkmann Starkmann requested a review from oliverklee July 31, 2024 12:33
@coveralls
Copy link

coveralls commented Jul 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10185208360

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 10184249487: 0.0%
Covered Lines: 46
Relevant Lines: 46
💛 - Coveralls

@oliverklee oliverklee changed the title [TASK] Add for showAction [TASK] Add functional tests for showAction Jul 31, 2024
oliverklee
oliverklee requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test generally looks good. There are some style warnings, though, and the branch needs a rebase.

Also, I'd prefer a cleaner solution over disabling cHash validation.

Tests/Functional/Controller/TeaControllerTest.php Outdated Show resolved Hide resolved
Tests/Functional/Controller/TeaControllerTest.php Outdated Show resolved Hide resolved
@Starkmann Starkmann force-pushed the tests/functionalShowAction branch from 63f4f16 to 8ac9240 Compare July 31, 2024 17:40
@oliverklee oliverklee force-pushed the tests/functionalShowAction branch from 951aaf0 to 647edec Compare December 24, 2024 10:01
oliverklee
oliverklee requested changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to have a look at the lowest test failures.

@oliverklee oliverklee force-pushed the tests/functionalShowAction branch from 4cd58e7 to e878ed6 Compare January 3, 2025 11:52
@coveralls
Copy link

coveralls commented Jan 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12610809806

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 12610684461: 0.0%
Covered Lines: 101
Relevant Lines: 101
💛 - Coveralls

@oliverklee oliverklee force-pushed the tests/functionalShowAction branch from e878ed6 to fb28ba7 Compare January 3, 2025 20:31
oliverklee added a commit that referenced this pull request Jan 3, 2025
@oliverklee
[TASK] Raise the minimum require bugfix version for TYPO3
731bec4 
This paves the way towards support for PHP 8.4.

Also, the newer version fixes a bug that affects functional tests
for the single view in #1419.
@oliverklee oliverklee mentioned this pull request Jan 3, 2025
Merged
oliverklee added a commit that referenced this pull request Jan 3, 2025
@oliverklee
[TASK] Raise the minimum require bugfix version for TYPO3
48874f1 
This paves the way towards support for PHP 8.4.

Also, the newer version fixes a bug that affects functional tests
for the single view in #1419.
oliverklee added a commit that referenced this pull request Jan 3, 2025
@oliverklee
[TASK] Raise the minimum required bugfix version for TYPO3
2bf6e12 
This paves the way towards support for PHP 8.4.

Also, the newer version fixes a bug that affects functional tests
for the single view in #1419.
DanielSiepmann pushed a commit that referenced this pull request Jan 4, 2025
@oliverklee
[TASK] Raise the minimum required bugfix version for TYPO3 (#1540)
5260d3d 
This paves the way towards support for PHP 8.4.

Also, the newer version fixes a bug that affects functional tests
for the single view in #1419.
@oliverklee oliverklee force-pushed the tests/functionalShowAction branch from fb28ba7 to 425722b Compare January 4, 2025 13:20
@oliverklee oliverklee merged commit 45f9479 into main Jan 4, 2025
56 checks passed
@oliverklee oliverklee deleted the tests/functionalShowAction branch January 4, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@Starkmann Starkmann

Labels
setup functional tests for requests
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.

Add a functional test for the Tea single view
3 participants
@Starkmann @coveralls @oliverklee