Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Update node to version 22 #1420

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[FEATURE] Update node to version 22 #1420

merged 1 commit into from
Aug 1, 2024

Conversation

cumuru
Copy link
Contributor

@cumuru cumuru commented Jul 31, 2024

Fixes #1403

@cumuru cumuru linked an issue Jul 31, 2024 that may be closed by this pull request
Update to Node.js 22 #1403
Closed
@coveralls
Copy link

coveralls commented Jul 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10185265850

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 10184249487: 0.0%
Covered Lines: 46
Relevant Lines: 46
💛 - Coveralls

oliverklee
oliverklee requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to update the Node.js version in the GitHub workflows.

@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Jul 31, 2024
@cumuru cumuru force-pushed the 1403-update-to-nodejs-22 branch from f8d159e to 337a574 Compare July 31, 2024 18:00
@cumuru
Copy link
Contributor Author

cumuru commented Jul 31, 2024

Fixed

@oliverklee oliverklee force-pushed the 1403-update-to-nodejs-22 branch from 337a574 to 9301347 Compare August 1, 2024 13:30
oliverklee
oliverklee approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oliverklee oliverklee enabled auto-merge (squash) August 1, 2024 13:31
@oliverklee oliverklee merged commit adc864f into main Aug 1, 2024
55 checks passed
@oliverklee oliverklee deleted the 1403-update-to-nodejs-22 branch August 1, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@cumuru cumuru

Labels
None yet
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.

Update to Node.js 22
3 participants
@cumuru @coveralls @oliverklee