Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Polish the runTests.sh help #1422

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[TASK] Polish the runTests.sh help #1422

merged 1 commit into from
Aug 1, 2024

Conversation

oliverklee
Copy link
Contributor

  • sort some lists
  • use the proper capitalization for PHPStan

@oliverklee
[TASK] Polish the runTests.sh help
67030e1 
- sort some lists
- use the proper capitalization for PHPStan
@oliverklee oliverklee added documentation Improvements or additions to documentation cleanup labels Aug 1, 2024
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Aug 1, 2024
@oliverklee oliverklee self-assigned this Aug 1, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10201806673

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 10199346878: 0.0%
Covered Lines: 46
Relevant Lines: 46
💛 - Coveralls

cumuru
cumuru suggested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@cumuru cumuru left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are four commands that are not documented:

I suggest to either add to the help text or drop them.
Thanks!

@oliverklee
Copy link
Contributor Author

There are four commands that are not documented:

I'd like to add those in a separate PR.

@cumuru cumuru merged commit 9c608ff into main Aug 1, 2024
55 checks passed
@cumuru cumuru deleted the cleanup/sort-runtests-help branch August 1, 2024 17:38
@oliverklee
Copy link
Contributor Author

There are four commands that are not documented:

Done: #1423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cumuru cumuru cumuru approved these changes

@DanielSiepmann DanielSiepmann Awaiting requested review from DanielSiepmann

@Starkmann Starkmann Awaiting requested review from Starkmann

@lukaszuznanski lukaszuznanski Awaiting requested review from lukaszuznanski

Assignees

@oliverklee oliverklee

Labels
cleanup documentation Improvements or additions to documentation
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @cumuru