Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Switch code coverage from PCOV to Xdebug #1429

Merged
merged 1 commit into from
Aug 23, 2024
Merged

[TASK] Switch code coverage from PCOV to Xdebug #1429

merged 1 commit into from
Aug 23, 2024

Conversation

oliverklee
Copy link
Contributor

PCOV is no longer maintainted, and nowadays Xdebug is fast enough.

@oliverklee
[TASK] Switch code coverage from PCOV to Xdebug
d9a7eac 
PCOV is no longer maintainted, and nowadays Xdebug is fast enough.
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Aug 23, 2024
@oliverklee oliverklee self-assigned this Aug 23, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10524562043

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 10466726225: 0.0%
Covered Lines: 46
Relevant Lines: 46
💛 - Coveralls

@DanielSiepmann
Copy link
Contributor

Can you share the source of "PCOV is unmaintained"?
https://github.com/sebastianbergmann/phpcov/ looks still active to me

@DanielSiepmann DanielSiepmann merged commit 920b2ca into main Aug 23, 2024
55 checks passed
@DanielSiepmann DanielSiepmann deleted the task/xdebug branch August 23, 2024 12:29
@oliverklee
Copy link
Contributor Author

The CLI tool PHPCOV (by Sebastian Bergmann) is something different than the PHP extension PCOV by Joe Watkins. The former is well-maintained, while the latter isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSiepmann DanielSiepmann DanielSiepmann approved these changes

@Starkmann Starkmann Awaiting requested review from Starkmann

@cumuru cumuru Awaiting requested review from cumuru

@lukaszuznanski lukaszuznanski Awaiting requested review from lukaszuznanski

@kanow kanow Awaiting requested review from kanow

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @DanielSiepmann