Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add Composer scripts and a CI job for Rector #1459

Merged
merged 2 commits into from
Sep 30, 2024
Merged

[FEATURE] Add Composer scripts and a CI job for Rector #1459

merged 2 commits into from
Sep 30, 2024

Conversation

oliverklee
Copy link
Contributor

Closes #851

@oliverklee oliverklee added the enhancement New feature or request label Sep 17, 2024
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Sep 17, 2024
@oliverklee oliverklee self-assigned this Sep 17, 2024
@oliverklee oliverklee force-pushed the feature/rector-scripts branch from a9e0499 to 4ad8638 Compare September 17, 2024 11:34
@coveralls
Copy link

coveralls commented Sep 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11072556665

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 11072312737: 0.0%
Covered Lines: 67
Relevant Lines: 67
💛 - Coveralls

@oliverklee oliverklee force-pushed the feature/rector-scripts branch from 4ad8638 to 0b0678a Compare September 17, 2024 12:33
lukaszuznanski
lukaszuznanski requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@lukaszuznanski lukaszuznanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is gitlab CI job missing there

@oliverklee
Copy link
Contributor Author

I've added the GitLab CI job now.

@oliverklee oliverklee force-pushed the feature/rector-scripts branch 2 times, most recently from 1290720 to 500e21c Compare September 17, 2024 15:40
@oliverklee
Copy link
Contributor Author

https://git.typo3.org/qa/example-extension/-/pipelines/66062

@oliverklee oliverklee force-pushed the feature/rector-scripts branch from 500e21c to 479cfe6 Compare September 18, 2024 11:44
@oliverklee oliverklee force-pushed the feature/rector-scripts branch from 479cfe6 to b2f301c Compare September 27, 2024 09:55
@oliverklee
Copy link
Contributor Author

@DanielSiepmann @lukaszuznanski gentle ping for a review :-)

@DanielSiepmann
Copy link
Contributor

DanielSiepmann commented Sep 27, 2024 •
edited
Loading

@oliverklee can you solve the conflicts introduced with merge of #1464 ?
But the PR itself is approved.

@oliverklee oliverklee force-pushed the feature/rector-scripts branch 2 times, most recently from b5df1f4 to 6c3d69d Compare September 27, 2024 12:13
@oliverklee
Copy link
Contributor Author

Rebased and repushed.

@DanielSiepmann
Copy link
Contributor

@oliverklee I can't merge. I guess @lukaszuznanski needs to review again to "remove" the requested change?

@oliverklee oliverklee force-pushed the feature/rector-scripts branch from 6c3d69d to 5ed0f25 Compare September 27, 2024 14:32
@lukaszuznanski lukaszuznanski merged commit a3d72de into main Sep 30, 2024
56 checks passed
@lukaszuznanski lukaszuznanski deleted the feature/rector-scripts branch September 30, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszuznanski lukaszuznanski lukaszuznanski approved these changes

@DanielSiepmann DanielSiepmann DanielSiepmann approved these changes

Assignees

@oliverklee oliverklee

Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.

Add Rector
5 participants
@oliverklee @coveralls @DanielSiepmann @lukaszuznanski @linxpinx