Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add php.ini from development for GitLab CI #1461

Closed
wants to merge 8 commits into from

Conversation

linxpinx
Copy link
Collaborator

Fixed #1214

@linxpinx linxpinx self-assigned this Sep 17, 2024
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Sep 17, 2024
@oliverklee oliverklee changed the title [TASK] Add php.ini from development [TASK] Add php.ini from development for GitLab CI Sep 17, 2024
@coveralls
Copy link

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 10905112515

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10903721040: 0.0%
Covered Lines: 67
Relevant Lines: 67

💛 - Coveralls

Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, the CI build is failing:

jobs:build-composer-dependencies config contains unknown keys: volumes

https://git.typo3.org/qa/example-extension/-/pipelines/66001

.gitlab/pipeline/ci/php.ini Outdated Show resolved Hide resolved
.gitlab/pipeline/jobs/.default.yml Outdated Show resolved Hide resolved
@linxpinx
Copy link
Collaborator Author

I have updated the PR can you review again? @oliverklee @lukaszuznanski

@oliverklee oliverklee force-pushed the TASK/use-development-php.ini-on-gitlab-ci branch from 0b12ce1 to 52988ce Compare September 17, 2024 14:25
@oliverklee oliverklee force-pushed the TASK/use-development-php.ini-on-gitlab-ci branch from 52988ce to debc51d Compare September 18, 2024 11:43
@linxpinx linxpinx closed this Oct 2, 2024
@linxpinx
Copy link
Collaborator Author

linxpinx commented Oct 2, 2024

I had to close this PR cause only PR created after 1.10.2024 and created with my Github Account will be seen by Hacktober.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the development PHP INI on CI in gitlab CI
3 participants