Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Bump the Symfony development dependencies #1468

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

oliverklee
Copy link
Contributor

For development versions, we don't need to bother supporting lower versions of dependencies.

@oliverklee oliverklee added the dependencies Pull requests that update a dependency file label Sep 21, 2024
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Sep 21, 2024
@oliverklee oliverklee self-assigned this Sep 21, 2024
@oliverklee oliverklee force-pushed the task/symfony-dev-deps branch from 59a92ba to 7c1adca Compare September 27, 2024 09:54
@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11071860891

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11069449819: 0.0%
Covered Lines: 67
Relevant Lines: 67

💛 - Coveralls

@oliverklee
Copy link
Contributor Author

@DanielSiepmann @lukaszuznanski gentle ping for a review :-)

Copy link
Contributor

@DanielSiepmann DanielSiepmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverklee approved if my question would be answered with no: Doesn't that prevent PHPStan, PHPUnit, etc. runs within CI against the lowest possible runtime dependencies, as require-dev constraints would raise the minimum version? And would you see this as an issue?

@oliverklee
Copy link
Contributor Author

@DanielSiepmann Yes, this change has affects on which versions of those dependencies get installed when we install the lowest dependencies for unit and functional tests.

Those are development dependencies: We're not using them directly in production code (although the TYPO3 Core code might possibly call them), but (in this case) only in CI jobs like XLIFF and YAML linting. So I don't think raising the dependencies would be an issue in such a way that it would keep us from catching real problems.

For development versions, we don't need to bother supporting
lower versions of dependencies.
@oliverklee oliverklee force-pushed the task/symfony-dev-deps branch from 7c1adca to f24a095 Compare September 27, 2024 13:47
@DanielSiepmann DanielSiepmann merged commit ef1e39b into main Sep 27, 2024
55 checks passed
@DanielSiepmann DanielSiepmann deleted the task/symfony-dev-deps branch September 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants