Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Use the development php.ini on GitLab CI #1481

Merged
merged 14 commits into from
Oct 7, 2024

Conversation

linxpinx
Copy link
Collaborator

@linxpinx linxpinx commented Oct 2, 2024

Start this PR for Hacktoberfest

@linxpinx linxpinx self-assigned this Oct 2, 2024
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Oct 2, 2024
@oliverklee oliverklee changed the title Task/use development php.ini on gitlab ci [TASK] Use the development php.ini on GitLab CI Oct 3, 2024
@oliverklee oliverklee force-pushed the TASK/use-development-php.ini-on-gitlab-ci branch from e46e0d8 to 012a9b1 Compare October 3, 2024 13:57
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails the pipeline with this message:

https://git.typo3.org/qa/example-extension/-/pipelines/66683
jobs:build-composer-dependencies config contains unknown keys: volumes

@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11221327896

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11204353868: 0.0%
Covered Lines: 67
Relevant Lines: 67

💛 - Coveralls

@linxpinx
Copy link
Collaborator Author

linxpinx commented Oct 7, 2024

I removed the key "volumes" cause it is unknown by GitLab. Replace it with a simple cp command.

@oliverklee
Copy link
Contributor

@linxpinx Did you already push the updated version? (I still see the version from 4 days ago.)

…ithub.com/FriendsOfTYPO3/tea into TASK/use-development-php.ini-on-gitlab-ci

# Conflicts:
#	.gitlab/pipeline/jobs/.default.yml
@linxpinx
Copy link
Collaborator Author

linxpinx commented Oct 7, 2024

You're right now the files are updated.

@oliverklee oliverklee merged commit f134e19 into main Oct 7, 2024
56 checks passed
@oliverklee oliverklee deleted the TASK/use-development-php.ini-on-gitlab-ci branch October 7, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants