[TASK] Move a repository test from unit to functional #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
force-pushed
the
task/move-repo-tests-to-functional
branch
from
67c2fd2 to
cde6a46
Compare
Unit tests for repositories are quite a hassle as we then need to set up all dependencies in `setUp()` ourselves. So convert the test to a functional tests where we can rely on the container to create and initialize the subject for us.
oliverklee
force-pushed
the
task/move-repo-tests-to-functional
branch
from
cde6a46 to
834f69e
Compare
Pull Request Test Coverage Report for Build 11204205781Details
💛 - Coveralls |
DanielSiepmann
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for repositories are quite a hassle as we then need to set up all dependencies in
setUp()ourselves.So convert the test to a functional tests where we can rely on the container to create and initialize the subject for us.