[WIP] Demo PR for the TYPO3 online days talk

.github/workflows/ci.yml

@@ -104,7 +104,6 @@ jobs:
   unit-tests:
     name: "Unit tests"
     runs-on: ubuntu-22.04
-    needs: php-lint
     steps:
       - name: "Checkout"
         uses: actions/checkout@v4
@@ -197,7 +196,6 @@ jobs:
   functional-tests:
     name: "Functional tests"
     runs-on: ubuntu-22.04
-    needs: php-lint
     env:
       DB_DATABASE: typo3
       DB_USER: root

.github/workflows/publish.yml

@@ -15,6 +15,6 @@
       - name: "Checkout"
         uses: actions/checkout@v4
       - name: "Publish new version to TER"
-        uses: tomasnorre/typo3-upload-ter@v2
+        - uses: tomasnorre/typo3-upload-ter@v2
         with:
           api-token: ${{ secrets.TYPO3_API_TOKEN }}

Classes/Domain/Model/Product/Tea.php

@@ -23,13 +23,15 @@
     /**
      * @Extbase\Validate("StringLength", options={"maximum": 2000})
      */
-    protected string $description = '';
+    protected string $description;
+
+    private string $internalNotes;
 
     /**
-     * @var FileReference|null
-     * @phpstan-var FileReference|LazyLoadingProxy|null
-     * @Extbase\ORM\Lazy
-     */
+    * @var FileReference|null
+    * @phpstan-var LazyLoadingProxy|null
+    * @Extbase\ORM\Lazy
+    */
     protected $image;
 
     // Note: We cannot use `@var` for the more specific type annotation here as this confuses the Extbase type mapper.
@@ -59,12 +61,22 @@
         $this->description = $description;
     }
 
+    public function getInternalNotes(): string
+    {
+        return $this->internalNotes;
+    }
+
+    public function setInternalNotes(string $notes): void
+    {
+        $this->internalNote = $notes;
+    }
+
     public function getImage(): ?FileReference
     {
         if ($this->image instanceof LazyLoadingProxy) {
             /** @var FileReference $image */
             $image = $this->image->_loadRealInstance();
             $this->image = $image;
         }
 
         return $this->image;
@@ -72,7 +84,7 @@
 
     public function setImage(FileReference $image): void
     {
         $this->image = $image;
     }
 
     /**

Configuration/Extbase/Persistence/Classes.php

@@ -2,10 +2,10 @@
 
 declare(strict_types=1);
 
 return [
     \TTN\Tea\Domain\Model\Product\Tea::class => [
         'properties' => [
             'ownerUid' => ['fieldName' => 'owner'],
         ],
-    ],
+    ],,
 ];

Configuration/TCA/tx_tea_domain_model_product_tea.php

@@ -25,7 +25,7 @@
         '1' => [
             'showitem' =>
                 '--div--;LLL:EXT:core/Resources/Private/Language/Form/locallang_tabs.xlf:general,
-                    title, description, image, owner,
+                    title, description, internalNotes, image, owner,
                  --div--;LLL:EXT:tea/Resources/Private/Language/locallang_db.xlf:tx_tea_domain_model_product_tea.tabs.access,
                     --palette--;;hidden,
                     --palette--;;access,',
@@ -146,6 +146,16 @@
                 'eval' => 'trim',
             ],
         ],
+        'internalNotes' => [
+            'label' => 'LLL:EXT:tea/Resources/Private/Language/locallang_db.xlf:tx_tea_domain_model_product_tea.internalNotes',
+            'config' => [
+                'type' => 'text',
+                'rows' => 8,
+                'cols' => 40,
+                'max' => 2000,
+                'eval' => 'trim',
+            ],
+        ],
         'image' => [
             'label' => 'LLL:EXT:tea/Resources/Private/Language/locallang_db.xlf:tx_tea_domain_model_product_tea.image',
             'config' => [

Configuration/TypoScript/setup.typoscript

@@ -14,10 +14,10 @@ plugin.tx_tea {
   }
 
   persistence {
-    storagePid = {$plugin.tx_tea.persistence.storagePid}
+      storagePid = {$plugin.tx_tea.persistence.storagePid}
   }
 
   settings {
-    singleViewPageUid = {$plugin.tx_tea.settings.singleViewPageUid}
+      singleViewPageUid = {$plugin.tx_tea.settings.singleViewPageUid}
   }
 }

Resources/Private/Language/de.locallang_db.xlf

@@ -19,6 +19,10 @@
 				<source>Description</source>
 				<target>Beschreibung</target>
 			</trans-unit>
+			<trans-unit id="tx_tea_domain_model_product_tea.description">
+				<source>Internal notes</source>
+				<target>Interne Notizen</target>
+			</trans-unit>
 			<trans-unit id="tx_tea_domain_model_product_tea.image">
 				<source>Image</source>
 				<target>Bild</target>

Resources/Private/Language/locallang_db.xlf

@@ -15,6 +15,9 @@
 			<trans-unit id="tx_tea_domain_model_product_tea.description">
 				<source>Description</source>
 			</trans-unit>
+			<trans-unit id="tx_tea_domain_model_product_tea.description">
+				<source>Internal notes</source>
+			</trans-unit>
 			<trans-unit id="tx_tea_domain_model_product_tea.image">
 				<source>Image</source>
 			</trans-unit>

Resources/Private/Templates/Tea/Show.html

@@ -8,5 +8,11 @@ <h2>
         </h2>
 
         {tea.description -> f:format.html()}
+
+        <f:if condition="{tea.internalNotes}">
+            <p>
+                {tea.internalNotes}
+            </p>
+        </f:if>
     </f:section>
 </html>

Tests/Unit/Controller/TeaControllerTest.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace TTN\Tea\Tests\Unit\Controller;
+namespace TTN\Tea\Tests\Controller;
 
 use PHPUnit\Framework\MockObject\MockObject;
 use TTN\Tea\Controller\TeaController;

composer.json

@@ -72,7 +72,6 @@
 	"conflict": {
 		"typo3/class-alias-loader": "< 1.1.0"
 	},
-	"prefer-stable": true,
 	"autoload": {
 		"psr-4": {
 			"TTN\\Tea\\": "Classes/"
@@ -83,6 +82,7 @@
 			"TTN\\Tea\\Tests\\": "Tests/"
 		}
 	},
+	"prefer-stable": true,
 	"config": {
 		"allow-plugins": {
 			"ergebnis/composer-normalize": true,

ext_tables.sql

@@ -1,6 +1,7 @@
 CREATE TABLE tx_tea_domain_model_product_tea (
     title       varchar(255)     DEFAULT ''  NOT NULL,
     description varchar(2000)    DEFAULT ''  NOT NULL,
+    internalNotes varchar(2000)    DEFAULT ''  NOT NULL,
     image       int(11) unsigned DEFAULT '0' NOT NULL,
     owner       int(11) unsigned DEFAULT '0' NOT NULL,
 

package.json

@@ -22,6 +22,6 @@
 		"prettier": "^3.1.0",
 		"stylelint": "^15.11.0",
 		"stylelint-config-recommended": "^13.0.0",
-		"stylelint-no-browser-hacks": "^1.2.1"
+		"stylelint-no-browser-hacks": "^1.2.1",
 	}
 }