Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Use own configuration files for tests #952

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

lukaszuznanski
Copy link
Contributor

Resolves: #902

@lukaszuznanski lukaszuznanski force-pushed the TASK/Use-own-configuration-files-for-tests branch from 2925abd to 600a919 Compare October 17, 2023 21:21
@oliverklee oliverklee added this to the 3.1.0: New features milestone Oct 18, 2023
@lukaszuznanski lukaszuznanski force-pushed the TASK/Use-own-configuration-files-for-tests branch from 4054218 to 62b1dcd Compare October 23, 2023 08:24
</testsuites>
<!-- @todo: change tag to 'coverage' when TF requires phpunit > 9 -->
<filter>
<!-- @todo: change tag to 'include' when TF requires phpunit > 9 -->
Copy link
Contributor

@oliverklee oliverklee Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're already using PHPUnit 9. So we should switch to coverage and include here.

@lukaszuznanski lukaszuznanski force-pushed the TASK/Use-own-configuration-files-for-tests branch from 84046a8 to ef124bb Compare October 25, 2023 16:04
@sbuerk
Copy link
Contributor

sbuerk commented Dec 19, 2023

@oliverklee @lukaszuznanski

Little bit late. TBH the bootstraps should also not be used from the the typo3/testing-framework vendor folder and copied to the project.

The background is, that there are scenarious where it's needed to make some changes based on the project/extension.

Beside this, the chosen location is kind of flattered. Configuration for all tools should be collected in one place and not distributed throughout a lot of places (and not the root folder)
to have a clean and "one place" to look it up. But that is maybe more a personally flavour - where I highly disagree to take this places as best practice.

@oliverklee
Copy link
Contributor

Thanks, I've created #1082 for moving these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use our own copies of the Testing Framework configuration files
3 participants