Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Make records timeable and hidable #989

Merged
merged 11 commits into from
Nov 27, 2023
Merged

[FEATURE] Make records timeable and hidable #989

merged 11 commits into from
Nov 27, 2023

Conversation

lukaszuznanski
Copy link
Contributor

@lukaszuznanski lukaszuznanski commented Nov 16, 2023 •
edited
Loading

Resolves: #553

Tested on v12 and v11

@lukaszuznanski lukaszuznanski self-assigned this Nov 16, 2023
@lukaszuznanski lukaszuznanski mentioned this pull request Nov 16, 2023
Closed
@lukaszuznanski lukaszuznanski marked this pull request as ready for review November 16, 2023 21:09
@lukaszuznanski lukaszuznanski added this to the 3.1.0: New features milestone Nov 16, 2023
@lukaszuznanski lukaszuznanski added the enhancement New feature or request label Nov 16, 2023
@oliverklee oliverklee force-pushed the Make-records-timeable-and-hidable branch from d416e28 to 2f7820d Compare November 17, 2023 11:24
oliverklee
oliverklee requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've manually tested this in a 11LTS and 12LTS backend: It works fine for me in both version. Thanks!

We should change a label, though.

CHANGELOG.md Outdated Show resolved Hide resolved
Configuration/TCA/tx_tea_domain_model_product_tea.php Outdated Show resolved Hide resolved
@lukaszuznanski lukaszuznanski force-pushed the Make-records-timeable-and-hidable branch from f6c79af to 63f743b Compare November 19, 2023 21:30
@lukaszuznanski lukaszuznanski force-pushed the Make-records-timeable-and-hidable branch from a16bf3d to 5a0faa9 Compare November 20, 2023 09:22
@oliverklee
Copy link
Contributor

Hm, this is strange. With the latest version (on another machine, though), I still see the "visibility of content element" label in V11, and don't see the new fields in the BE in V12 at all.

@lukaszuznanski
Copy link
Contributor Author

Hm, this is strange. With the latest version (on another machine, though), I still see the "visibility of content element" label in V11, and don't see the new fields in the BE in V12 at all.

Fixed by now, it's resolved in palette.

@lukaszuznanski lukaszuznanski force-pushed the Make-records-timeable-and-hidable branch from d78eb12 to 9d98e58 Compare November 27, 2023 12:01
@lukaszuznanski lukaszuznanski force-pushed the Make-records-timeable-and-hidable branch from 9d98e58 to d95a4b0 Compare November 27, 2023 12:14
oliverklee
oliverklee approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on my V11 and V12 installations. Thanks!

@oliverklee oliverklee merged commit 53b0abd into main Nov 27, 2023
51 checks passed
@oliverklee oliverklee deleted the Make-records-timeable-and-hidable branch November 27, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@lukaszuznanski lukaszuznanski

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.1.0: New features
Development

Successfully merging this pull request may close these issues.

Make records hidable and timeable
2 participants
@lukaszuznanski @oliverklee