[TASK] Add permalink tests and third party document permalink resolving #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legacy_hook/composer.lockPackage changes
Settings · Docs · Powered by Private Packagist |
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
Comment on lines
251
to
256
| $resolvedVersionEnum = Typo3VersionMapping::tryFrom($version); | ||
| if ($resolvedVersionEnum === null) { | ||
| $resolvedVersion = $version; | ||
| } else { | ||
| $resolvedVersion = $resolvedVersionEnum->getVersion(); | ||
| } |
There was a problem hiding this comment.
Can be shortened to
Suggested change
| $resolvedVersionEnum = Typo3VersionMapping::tryFrom($version); | |
| if ($resolvedVersionEnum === null) { | |
| $resolvedVersion = $version; | |
| } else { | |
| $resolvedVersion = $resolvedVersionEnum->getVersion(); | |
| } | |
| $resolvedVersion = Typo3VersionMapping::tryFrom($version)?->getVersion() ?? $version; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple of related things:
t3docs/typo3-version-handlingt3docs/typo3-version-handlingto latest version (to deal with 13.4 releases)Happy reviewing :-)