fix: improve download logging (#325)

* Suggest use `-it` so docker run generate progress bar of downloading information properly * add info! log for model download
TabbyML · Aug 2, 2023 · 57c811b · 57c811b
1 parent b8308b7
commit 57c811b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/tabby-download/Cargo.toml b/crates/tabby-download/Cargo.toml
@@ -11,4 +11,5 @@ reqwest = { version = "0.11.18", features = ["stream", "json"] }
 anyhow = { workspace = true }
 serde = { workspace = true }
 serdeconv = { workspace = true }
+tracing = { worksapce = true }
 tokio-retry = "0.3.0"
diff --git a/crates/tabby-download/src/lib.rs b/crates/tabby-download/src/lib.rs
@@ -11,6 +11,7 @@ use tokio_retry::{
     strategy::{jitter, ExponentialBackoff},
     Retry,
 };
+use tracing::info;
 
 impl CacheInfo {
     async fn download(
@@ -62,6 +63,8 @@ pub async fn download_model(model_id: &str, prefer_local_file: bool) -> Result<(
         return Ok(());
     }
 
+    info!("Start downloading model `{}`", model_id);
+
     let mut cache_info = CacheInfo::from(model_id).await;
 
     let optional_files = vec![

diff --git a/website/docs/self-hosting/01-docker.mdx b/website/docs/self-hosting/01-docker.mdx
@@ -11,7 +11,7 @@ import TabItem from '@theme/TabItem';
   <TabItem value="shell" label="Shell" default>
 
   ```bash title="run.sh"
-  docker run \
+  docker run -it \
     -p 8080:8080 -v $HOME/.tabby:/data \
     tabbyml/tabby serve --model TabbyML/SantaCoder-1B
   ```
@@ -43,7 +43,7 @@ services:
   <TabItem value="shell" label="Shell" default>
 
   ```bash title="run.sh"
-  docker run \
+  docker run -it \
     --gpus all -p 8080:8080 -v $HOME/.tabby:/data \
     tabbyml/tabby \
     serve --model TabbyML/SantaCoder-1B --device cuda