feat(vscode): adding auto-import during accept inline completion item #3389
+59
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icycodes
reviewed
Nov 14, 2024
icycodes
reviewed
Nov 14, 2024
icycodes
reviewed
Nov 14, 2024
icycodes
reviewed
Nov 14, 2024
icycodes
reviewed
Nov 14, 2024
icycodes
reviewed
Nov 14, 2024
clients/vscode/src/Commands.ts
Outdated
Comment on lines
232
to
239
|
|
||
| commands.executeCommand("editor.action.inlineSuggest.commit"); | ||
|
|
||
| const uri = editor.document.uri; | ||
| const range = this.inlineCompletionProvider.getCurrentDisplayRange(); | ||
| if (!range) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| commands.executeCommand("editor.action.inlineSuggest.commit"); | |
| const uri = editor.document.uri; | |
| const range = this.inlineCompletionProvider.getCurrentDisplayRange(); | |
| if (!range) { | |
| return; | |
| } | |
| const range = this.inlineCompletionProvider.getCurrentDisplayRange(); | |
| await commands.executeCommand("editor.action.inlineSuggest.commit"); | |
| const uri = editor.document.uri; | |
| if (!range) { | |
| return; | |
| } |
There was a problem hiding this comment.
Should it await the edit action of accept inline completion?
There was a problem hiding this comment.
The await causes us to be unable to get the current display item because it is no longer available. I moved the part that retrieves the edited range before committing the inline suggestion. The range should always exist if a code prediction is present.
icycodes
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still working
Screen.Recording.2024-11-08.at.03.45.50.mov
fix #2965